Skip to content

Commit 229ff39

Browse files
committed
board: the CI gap was the trigger, not the coverage
Codex P2 on #82, verified against .github/workflows/lint.yml: the claim that no CI job here compiles the native crate is false -- the clippy and rust-test jobs check out the lance-graph sibling and run cargo clippy --all-targets and cargo test from native/lgj-abi on every push and PR to this repo. The real gap is the trigger: on {pull_request, push} fires for this repository only, so an upstream-only merge in lance-graph cannot start the workflow and the break stays invisible until someone pushes here. Corrected in place in the unmerged #81 arc entry, and by prepend for the merged epiphany. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HScwwezRdMxFfTs3WLG19d
1 parent 42e45a3 commit 229ff39

2 files changed

Lines changed: 35 additions & 4 deletions

File tree

‎.claude/board/EPIPHANIES.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,25 @@
1+
## E-THE-CI-GAP-WAS-THE-TRIGGER-NOT-THE-COVERAGE-1 (2026-09-19)
2+
3+
⊘ **Corrects `E-THE-VALHALLA-FLIP-COST-ONE-WORD-SIX-TIMES-…-1` below**, which
4+
says the `RangeOutOfBounds` break went unseen *"because no CI job here compiles
5+
the native crate."* **That is false, and checkable in one file.**
6+
`.github/workflows/lint.yml` runs `clippy` and `rust-test` jobs that check out
7+
sibling `AdaWorldAPI/lance-graph` (and `ndarray`, and `OGAR`) and then run
8+
`cargo clippy --all-targets -- -D warnings` and `cargo test` from
9+
`native/lgj-abi`. The native crate is compiled against the real sibling on
10+
every push and PR **to this repository**.
11+
12+
**The actual hazard is the TRIGGER.** The workflow is `on: {pull_request,
13+
push}`, which fires for events in *this* repo only. An upstream-only merge in
14+
lance-graph — exactly what added `ExecError::RangeOutOfBounds` — cannot start
15+
it, so the break stayed invisible until the next push here. Coverage was never
16+
missing; the *event* was.
17+
18+
**Why the wrong diagnosis was worse than no diagnosis:** it would have sent the
19+
next session to add a CI job that already exists, and left the real gap — no
20+
upstream-change notification — untouched. Found by Codex P2 on #82; I verified
21+
it against the workflow rather than accepting or dismissing the finding.
22+
123
## E-PANAMA-TIMES-VALHALLA-IS-ONE-MEMBRANE-AND-THE-LAB-FINALLY-HAS-ONE-VARIABLE-1 (2026-09-19)
224

325
**Operator reframing, and it is the correct one:** this was never a JDK 26→28

‎.claude/board/PR_ARC_INVENTORY.md‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,19 @@
3030
`Pred::Range` work and `exec_error_to_status` matches exhaustively. Mapped
3131
into the documented *"bug in THIS file"* family — no new public status, no
3232
ABI bump — and fenced by the falsifier above, **disable-verified
33-
red-then-green**. *Standing hazard worth the sentence: an exhaustive match
34-
across a repo boundary turns an upstream ADDITIVE change into a downstream
35-
build failure, and no CI job here compiles the native crate, so nothing saw
36-
it.*
33+
red-then-green**. *Standing hazard, corrected before merge (Codex P2 on #82,
34+
verified against `.github/workflows/lint.yml`): an exhaustive match across a
35+
repo boundary turns an upstream ADDITIVE change into a downstream build
36+
failure. ⊘ The first draft blamed the wrong thing — it said "no CI job here
37+
compiles the native crate", which is FALSE: the `clippy` and `rust-test`
38+
jobs check out sibling `AdaWorldAPI/lance-graph` and run
39+
`cargo clippy --all-targets` / `cargo test` from `native/lgj-abi`, so CI
40+
compiles it on every push and PR **to this repo**. The real gap is the
41+
TRIGGER, not the coverage: `on: {pull_request, push}` fires on this
42+
repository only, so an upstream-only merge in lance-graph cannot start this
43+
workflow and the break stays invisible until someone pushes here. Naming it
44+
as missing coverage would have sent the next session to add a job that
45+
already exists.*
3746
- **Measured** (Temurin `28+16-ea`, fresh `liblgj_abi.so` abi 0.11 avx512):
3847
**183 native tests**; **`ALL PASSED (409 checks)`** — byte-for-byte the same
3948
409 as the unflipped baseline **on the same JDK**, which is the comparison

0 commit comments

Comments
 (0)