Skip to content

Commit b1189cb

Browse files
committed
board: the credential fix is verified at runtime, not just in YAML
`java-suites` is green on 2a30039 (`ALL PASSED (612 checks)`, all four consumer suites), so the persist-credentials change is proven not to break the four sibling checkouts. The stronger evidence is in the runner log: each checkout prints `persist-credentials: false`, then `Setting up auth`, then `Removing auth` INSIDE the checkout step. So auth exists only long enough to clone and is gone before the `cargo build` that can execute a repository-controlled `build.rs`. Without the flag there is no in-step `Removing auth` at all and the config survives to post-job cleanup, spanning every intervening step. That is the difference between asserting a config value and measuring the mechanism. Also records the second finding's full chain, including the defect I introduced while fixing it and the false finding I nearly filed from mtimes alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
1 parent 2a30039 commit b1189cb

1 file changed

Lines changed: 29 additions & 0 deletions

File tree

‎.claude/board/LATEST_STATE.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,35 @@ host reports `avx512`, and all 765 counts are byte-identical, which turns the
4444
backend-agnostic claim from something read out of the tests into something
4545
observed across two backends.
4646

47+
**Review follow-up (`2a30039`), both findings CodeRabbit-confirmed.** Two real
48+
defects, both mine:
49+
50+
- **Persisted checkout credentials** (zizmor `artipacked`). Fixed on ALL
51+
THIRTEEN checkout steps, not the four named — `persist-credentials` appeared
52+
nowhere in the file, every job runs `cargo`, so the `build.rs` read path was
53+
identical in `format`/`clippy`/`rust-test`. Verified free first: nothing
54+
pushes, `contents: read`, no secret read. **Verified at RUNTIME, not just in
55+
YAML** — each of the four checkouts logs `persist-credentials: false`, then
56+
`Setting up auth`, then `Removing auth` INSIDE the checkout step, so the
57+
credential no longer spans the later `cargo build`. Without the flag there is
58+
no in-step `Removing auth` and the config survives to post-job cleanup.
59+
- **The documented suite command could not run.** My own pointer sentence aimed
60+
at a JDK 25/26 command without the preview flags; measured `error: value
61+
classes are a preview feature and are disabled by default`, exit 1. Fixing it
62+
surfaced three more in the same block (`/usr/lib/jvm` now holds only Java 21
63+
so `temurin-26-jdk-amd64` does not exist here; the block mixed working
64+
directories and died on `find: 'java/src/main'`; `-Dlgj.library=$PWD/target/...`
65+
named an incidental leftover `target/` that is a separate inode from what
66+
step 1 builds) — and one I INTRODUCED, caught only by executing it:
67+
`--manifest-path` instead of `cd` broke the toolchain, because rustup reads
68+
`rust-toolchain.toml` from the CWD (`rustc 1.94.1 is not supported`, exit
69+
101). The `cd` is load-bearing and is back in a subshell. Verified by
70+
extracting the fenced block by PARSE and running it under `bash -e`: exit 0,
71+
`ALL PASSED (612 checks)`.
72+
I also nearly filed a FALSE finding — the two `.so` paths have different
73+
mtimes, which read as a stale artifact; they are md5-identical. Checking
74+
content instead of timestamps stopped it.
75+
4776
**OPEN:** nothing on this. The remaining gap is elsewhere and unchanged —
4877
`lint.yml` fires `on: {pull_request, push}` for THIS repository only, so an
4978
upstream-only merge in `lance-graph` or `ndarray` cannot start the workflow and

0 commit comments

Comments
 (0)