Repository navigation
Commit 68c0909
committed
ci: move ndarray's hardcoded toolchain pins to 1.98.1 too
Caught by reading the PR's own check names: CI reported tests/1.97.1 and
clippy/1.97.1 AFTER the toolchain file said 1.98.1. Unlike lance-graph, whose
eleven workflows all read rust-toolchain.toml with no toolchain input, this
repo's CI pins the version explicitly via dtolnay/rust-toolchain@<version> plus
an MSRV env var. So bumping rust-toolchain.toml alone left CI still testing the
OLD toolchain — the bump would have been cosmetic where it is actually gated.
Six real pins moved: MSRV, BLAS_MSRV, the clippy matrix entry, and three
dtolnay/rust-toolchain@ steps.
Six comments also restated the version in prose and are rewritten rather than
edited, the same lesson rust-toolchain.toml already carries: a stale comment on
a version pin is how the next reader learns the wrong number. The matrix
comment now names WHERE the number lives (three places in this file, because CI
does not read the toolchain file) instead of duplicating the number itself, and
points at the bump log as the single record of why each move happened. The
comment it replaces still described the 1.94.1 bump as 'this PR'.
Verified: zero remaining 1.97.1 references in ci.yaml, and the YAML parses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V1 parent 2095b76 commit 68c0909
1 file changed
Lines changed: 19 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
| 24 | + | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
50 | 51 | | |
51 | | - | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | | - | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
102 | | - | |
| 103 | + | |
103 | 104 | | |
104 | 105 | | |
105 | 106 | | |
| |||
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
129 | | - | |
| 130 | + | |
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
| |||
155 | 156 | | |
156 | 157 | | |
157 | 158 | | |
158 | | - | |
| 159 | + | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| |||
210 | 211 | | |
211 | 212 | | |
212 | 213 | | |
213 | | - | |
| 214 | + | |
214 | 215 | | |
215 | 216 | | |
216 | 217 | | |
| |||
0 commit comments