Skip to content

Commit 67b908a

Browse files
authored
Add subtle inverse recipes to Designer plugin (#251)
* Add subtle inverse recipes to Designer plugin * Fix string comparison casing issues
1 parent 58eaa07 commit 67b908a

6 files changed

Lines changed: 32 additions & 4 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Add subtle inverse recipes to Designer plugin",
4+
"packageName": "@adaptive-web/adaptive-ui-designer-core",
5+
"email": "47367562+bheston@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fix string comparison casing issues",
4+
"packageName": "@adaptive-web/adaptive-ui-designer-figma",
5+
"email": "47367562+bheston@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/adaptive-ui-designer-core/src/registry/recipes.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
accentFillReadable,
77
accentFillStealth,
88
accentFillSubtle,
9+
accentFillSubtleInverse,
910
accentStrokeDiscernible,
1011
accentStrokeReadable,
1112
accentStrokeSafety,
@@ -22,6 +23,7 @@ import {
2223
criticalFillReadable,
2324
criticalFillStealth,
2425
criticalFillSubtle,
26+
criticalFillSubtleInverse,
2527
criticalStrokeDiscernible,
2628
criticalStrokeReadable,
2729
criticalStrokeSafety,
@@ -54,6 +56,7 @@ import {
5456
highlightFillReadable,
5557
highlightFillStealth,
5658
highlightFillSubtle,
59+
highlightFillSubtleInverse,
5760
highlightStrokeDiscernible,
5861
highlightStrokeReadable,
5962
highlightStrokeSafety,
@@ -65,6 +68,7 @@ import {
6568
infoFillReadable,
6669
infoFillStealth,
6770
infoFillSubtle,
71+
infoFillSubtleInverse,
6872
infoStrokeDiscernible,
6973
infoStrokeReadable,
7074
infoStrokeSafety,
@@ -94,6 +98,7 @@ import {
9498
neutralFillReadable,
9599
neutralFillStealth,
96100
neutralFillSubtle,
101+
neutralFillSubtleInverse,
97102
neutralStrokeDiscernible,
98103
neutralStrokeReadable,
99104
neutralStrokeSafety,
@@ -112,6 +117,7 @@ import {
112117
successFillReadable,
113118
successFillStealth,
114119
successFillSubtle,
120+
successFillSubtleInverse,
115121
successStrokeDiscernible,
116122
successStrokeReadable,
117123
successStrokeSafety,
@@ -141,6 +147,7 @@ import {
141147
warningFillReadable,
142148
warningFillStealth,
143149
warningFillSubtle,
150+
warningFillSubtleInverse,
144151
warningStrokeDiscernible,
145152
warningStrokeReadable,
146153
warningStrokeSafety,
@@ -223,42 +230,49 @@ const colorTokens: DesignTokenOrGroupStore = [
223230
accentBaseColor,
224231
accentFillStealth,
225232
accentFillSubtle,
233+
accentFillSubtleInverse,
226234
accentFillIdeal,
227235
accentFillDiscernible,
228236
accentFillReadable,
229237
highlightBaseColor,
230238
highlightFillStealth,
231239
highlightFillSubtle,
240+
highlightFillSubtleInverse,
232241
highlightFillIdeal,
233242
highlightFillDiscernible,
234243
highlightFillReadable,
235244
criticalBaseColor,
236245
criticalFillStealth,
237246
criticalFillSubtle,
247+
criticalFillSubtleInverse,
238248
criticalFillIdeal,
239249
criticalFillDiscernible,
240250
criticalFillReadable,
241251
warningBaseColor,
242252
warningFillStealth,
243253
warningFillSubtle,
254+
warningFillSubtleInverse,
244255
warningFillIdeal,
245256
warningFillDiscernible,
246257
warningFillReadable,
247258
successBaseColor,
248259
successFillStealth,
249260
successFillSubtle,
261+
successFillSubtleInverse,
250262
successFillIdeal,
251263
successFillDiscernible,
252264
successFillReadable,
253265
infoBaseColor,
254266
infoFillStealth,
255267
infoFillSubtle,
268+
infoFillSubtleInverse,
256269
infoFillIdeal,
257270
infoFillDiscernible,
258271
infoFillReadable,
259272
neutralBaseColor,
260273
neutralFillStealth,
261274
neutralFillSubtle,
275+
neutralFillSubtleInverse,
262276
neutralFillIdeal,
263277
neutralFillDiscernible,
264278
neutralFillReadable,

packages/adaptive-ui-designer-figma-plugin/src/figma/node.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,11 @@ export class FigmaPluginNode extends PluginNode {
288288
}
289289

290290
if (this._node.type === "COMPONENT") {
291-
const disabled: string | null = this._node.variantProperties ? this._node.variantProperties[disabledVariant] : null;
291+
const disabled: string | null = this._node.variantProperties ? this._node.variantProperties[disabledVariant]?.toLowerCase() : null;
292292
const state: State | undefined = this._node.variantProperties ? this._node.variantProperties[stateVariant] as State : undefined;
293293
this._state = disabled === "true" ? "Disabled" : state;
294294
} else if (this._node.type === "INSTANCE") {
295-
const disabled: string | null = this._node.componentProperties[disabledVariant]?.value as string;
295+
const disabled: string | null = (this._node.componentProperties[disabledVariant]?.value as string)?.toLowerCase();
296296
const state: State = this._node.componentProperties[stateVariant]?.value as State;
297297
this._state = disabled === "true" ? "Disabled" : state;
298298
}

packages/adaptive-ui-designer-figma-plugin/src/ui/ui-controller-code.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class CodeController {
2121
*/
2222
public selectedNodesChanged() {
2323
this.supportsCodeGen = this.controller.selectedNodes.length === 1 &&
24-
this.controller.selectedNodes[0].additionalData.get(AdditionalDataKeys.supportsCodeGen) === "true";
24+
this.controller.selectedNodes[0].additionalData.get(AdditionalDataKeys.supportsCodeGen).toLowerCase() === "true";
2525
// console.log("change", this.supportsCodeGen);
2626
}
2727

packages/adaptive-ui-designer-figma/src/lib/anatomy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ function isContextNode(node: PluginUINodeData, componentName: string): boolean {
234234
}
235235

236236
function walkNode(node: PluginUINodeData, componentName: string, condition: Record<string, string | boolean> | undefined, anatomy: Anatomy): void {
237-
if (node.name === "Focus indicator") {
237+
if (node.name.toLowerCase() === "focus indicator") {
238238
// Ignore for now
239239
return;
240240
}

0 commit comments

Comments
 (0)