Switch from coverage and pylint to pytest-cov and ruff

Author: AgenttiX

.github/workflows/main.yml

@@ -56,23 +56,18 @@ jobs:
           restore-keys: |
             pip-${{ runner.os }}-
             pip-
-      - name: Install apt requirements
-        run: |
-          sudo apt-get update
-          sudo apt-get install gcc libssl-dev python3-dev swig
       - name: Install requirements
         run: |
           pip --cache-dir=.pip install --upgrade pip
-          pip --cache-dir=.pip install pylint -r requirements.txt
-      - name: Run Pylint
-        run: pylint startup tests ./*.py 2>&1 | tee pylint.txt
-        working-directory: ${{ github.workspace }}
+          pip --cache-dir=.pip install -r requirements.txt
+      - name: Lint with ruff
+        uses: astral-sh/ruff-action@v4.1.0
+        args: check --exit-zero
       - name: Upload results
         uses: actions/upload-artifact@v7
         with:
           name: Lint
-          path: |
-            ${{ github.workspace }}/pylint.txt
+          path: ruff.txt
           if-no-files-found: error
   sast:
     # The SAST scanner action is based on Docker, and therefore does not work on ubuntu-slim.
@@ -114,27 +109,21 @@ jobs:
         sudo apt-get update
         sudo apt-get install -y bleachbit chkrootkit fwupd rkhunter modemmanager
         pip --cache-dir=.pip install --upgrade pip
-        pip --cache-dir=.pip install coverage
         pip --cache-dir=.pip install -r requirements.txt
-    - name: Run tests with coverage
-      run: coverage run
-      working-directory: ${{ github.workspace }}
-    - name: Create coverage reports
+    - name: Run tests
       run: |
-        coverage report | tee coverage.txt
-        coverage html
-        coverage xml
-        coverage json
-      working-directory: ${{ github.workspace }}
+        set -o pipefail
+        pytest | tee test-output.txt
     - name: Upload results
       uses: actions/upload-artifact@v7
       with:
         name: Coverage
         path: |
-          ${{ github.workspace }}/coverage.txt
-          ${{ github.workspace }}/coverage.xml
-          ${{ github.workspace }}/coverage.json
-          ${{ github.workspace }}/htmlcov
+         .test_durations
+          coverage.xml
+          coverage.json
+          htmlcov
+          test-output.txt
         if-no-files-found: error
     - name: Upload results to Codecov
       uses: codecov/codecov-action@v7

requirements.txt

@@ -4,7 +4,6 @@
 # adb >= 1.3.0
 
 # chkcrontab >= 1.7
-
 exif >= 1.6.0
 
 # gplaycli >= 3.29
@@ -14,17 +13,17 @@ exif >= 1.6.0
 # TODO: Try this instead.
 # https://github.com/89z/googleplay
 
+pytest >= 9.1.1
+pytest-cov >= 7.1.0
+
 # For Wacom script
 # Despite the warning from FOSSA, python-xlib is licensed with LGPLv2+
 # https://github.com/python-xlib/python-xlib
 # https://pypi.org/project/python-xlib/
 python-xlib >= 0.33
 
 # qmk >= 1.0.0
-
 requests >= 2.32.3
-
-# For LibreNMS log spam cleaner
-slack-cleaner2 >= 3.2.7
-
+ruff >= 0.16.6
+slack-cleaner2 >= 3.2.7  # For LibreNMS log spam cleaner
 # tasmotizer >= 1.2.1