BaseCluster: initialise errors to 0 by default

Following review: rather than setting sigmaYZ explicitly in CheckResid,
zero-initialise mSigmaY2/mSigmaZ2/mSigmaYZ in BaseCluster so that
default-constructed clusters (e.g. the PV pseudo-cluster in CheckResid)
never carry uninitialised error terms.

Author: hyungjun-lee

DataFormats/Reconstruction/include/ReconstructionDataFormats/BaseCluster.h

@@ -34,9 +34,9 @@ class BaseCluster
 {
  private:
   math_utils::Point3D<T> mPos; // cartesian position
-  T mSigmaY2;                  // error in Y direction (usually rphi)
-  T mSigmaZ2;                  // error in Z direction (usually Z)
-  T mSigmaYZ;                  // non-diagonal term of error matrix
+  T mSigmaY2 = 0;              // error in Y direction (usually rphi)
+  T mSigmaZ2 = 0;              // error in Z direction (usually Z)
+  T mSigmaYZ = 0;              // non-diagonal term of error matrix
   std::uint16_t mSensorID = 0; // the sensor id
   std::int8_t mCount = 0;      // user field reserved for counting
   std::uint8_t mBits = 0;      // user field reserved for bit flags

Detectors/GlobalTrackingWorkflow/study/src/CheckResidSpec.cxx

@@ -453,7 +453,6 @@ bool CheckResidSpec::processITSTrack(const o2::its::TrackITS& iTrack, const o2::
     bcPV.setSigmaY2(0.5 * (pv.getSigmaX2() + pv.getSigmaY2()));
     bcPV.setSigmaZ2(pv.getSigmaZ2());
     bcPV.setSensorID(-1);
-    bcPV.setSigmaYZ(0.f); // not initialised by the BaseCluster default constructor
     clArr[0] = &bcPV;
   }
   // collect all track clusters to array, placing them to layer+1 slot