Skip to content

Commit d01caa6

Browse files
mconcasdavidrohr
authored andcommitted
GPU Display: require GLFW >= 3.4
GPUDisplayFrontendGlfw.cxx uses glfwGetPlatform() and the GLFW_PLATFORM_* constants, introduced in GLFW 3.4. Without a minimum version the lookup accepted older system installs and the build failed at compile time instead of at configuration. Assisted by Claude Code
1 parent 8cd2f89 commit d01caa6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎GPU/GPUTracking/Standalone/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ else()
8686
endif()
8787

8888
if(GPUCA_BUILD_EVENT_DISPLAY)
89-
find_package(GLFW NAMES glfw3 CONFIG REQUIRED)
89+
find_package(GLFW 3.4 NAMES glfw3 CONFIG REQUIRED)
9090
find_package(GLEW REQUIRED)
9191
find_package(GLUT REQUIRED)
9292
find_package(OpenGL REQUIRED)

‎dependencies/FindGLFW.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
# granted to it by virtue of its status as an Intergovernmental Organization
1010
# or submit itself to any jurisdiction.
1111

12-
# Simply provide a namespaced alias for the existing target
12+
# Simply provide a namespaced alias for the existing target
1313

14-
find_package(GLFW NAMES glfw3 CONFIG)
14+
find_package(GLFW 3.4 NAMES glfw3 CONFIG)
1515
if(NOT GLFW_FOUND)
1616
return()
1717
endif()

0 commit comments

Comments
 (0)