Merge branch 'AliceO2Group:master' into master

Author: sawankumawat

.claude/commands/migrate-ccdb.md

@@ -36,7 +36,7 @@
 /PWGCF/DataModel @alibuild @jgrosseo @jaelpark @victor-gonzalez @dsarkaralice @lauraser
 /PWGCF/TableProducer @alibuild @jgrosseo @jaelpark @victor-gonzalez @dsarkaralice @lauraser
 /PWGCF/Tasks @alibuild @jgrosseo @jaelpark @victor-gonzalez @dsarkaralice @lauraser
-/PWGCF/EbyEFluctuations @alibuild @SwatiSaha-1997 @isputows @victor-gonzalez @dsarkaralice @lauraser
+/PWGCF/EbyEFluctuations @alibuild @SwatiSaha-1997 @isputows @victor-gonzalez @dsarkaralice @lauraser @fsii
 /PWGCF/Femto @alibuild @lauraser @ariedel-cern @dimihayl @victor-gonzalez @dsarkaralice @wrzesaCERN
 /PWGCF/FemtoDream @alibuild @lauraser @ariedel-cern @dimihayl @victor-gonzalez @dsarkaralice @wrzesaCERN
 /PWGCF/Femto3D @alibuild @glromane @sofiatomassini @lauraser @dimihayl @victor-gonzalez @dsarkaralice @wrzesaCERN

CODEOWNERS

@@ -1009,8 +1009,12 @@ struct EventSelectionQaTask {
 
       // special check to avoid crashes (in particular, on some MC Pb-Pb datasets)
       // (related to shifts in ambiguous tracks association to bc slices (off by 1) - see https://mattermost.web.cern.ch/alice/pl/g9yaaf3tn3g4pgn7c1yex9copy
-      if (ambTrId >= 0 && (ambTracks.iteratorAt(ambTrId).bcIds()[0] >= bcs.size()))
-        continue;
+      // an empty slice (-1, -1) passes the upper check, so test it as well
+      if (ambTrId >= 0) {
+        const auto& ambTrack = ambTracks.iteratorAt(ambTrId);
+        if (!ambTrack.has_bc() || ambTrack.bcIds()[0] >= bcs.size() || ambTrack.bcIds()[1] >= bcs.size())
+          continue;
+      }
 
       int indexBc = ambTrId < 0 ? track.collision_as<ColEvSels>().bc_as<BCsRun3>().globalIndex() : ambTracks.iteratorAt(ambTrId).bc_as<BCsRun3>().begin().globalIndex();
       auto bc = bcs.iteratorAt(indexBc);

DPG/Tasks/AOTEvent/eventSelectionQa.cxx

@@ -43,6 +43,7 @@
 
 #include <Rtypes.h>
 
+#include <array>
 #include <cmath>
 #include <cstddef>
 #include <cstdint>
@@ -187,37 +188,37 @@ struct MultiparticleCorrelationsMei // this name is used in lower-case format to
   // *) Define and initialize all data members to be called in the main process* functions:
   // **) Task configuration:
   struct TaskConfiguration {
-    bool fProcess[eProcess_N] = {false}; // Set what to process. See enum EProcess for full description. Set via implicit variables within a PROCESS_SWITCH clause.
-    bool fDryRun = false;                // book all histos and run without filling and calculating anything
-  } tc;                                  // you have to prepend "tc." for all objects name in this group later in the code
+    std::array<bool, eProcess_N> fProcess{false}; // Set what to process. See enum EProcess for full description. Set via implicit variables within a PROCESS_SWITCH clause.
+    bool fDryRun = false;                         // book all histos and run without filling and calculating anything
+  } tc;                                           // you have to prepend "tc." for all objects name in this group later in the code
 
   // **) Particle histograms:
   struct ParticleHistograms {
-    TList* fParticleHistogramsList = NULL; //!<! list to hold all control particle histograms
-    TH1F* fParticleHistograms[eParticleHistograms_N][2][2] = {{{NULL}}};
+    TList* fParticleHistogramsList = nullptr; //!<! list to hold all control particle histograms
+    std::array<std::array<std::array<TH1F*, 2>, 2>, eParticleHistograms_N> fParticleHistograms{};
   } pc; // you have to prepend "pc." for all objects name in this group later in the code
 
   // *) Event histograms:
   struct EventHistograms {
-    TList* fEventHistogramsList = NULL;                            //!<! list to hold all event-level histograms
-    TH1F* fEventHistograms[eEventHistograms_N][2][2] = {{{NULL}}}; //! [ type - see enum EEventHistograms ][reco,sim][before, after event cuts]
-  } ec;                                                            // prepend "ec." for event counters
+    TList* fEventHistogramsList = nullptr;                                                  //!<! list to hold all event-level histograms
+    std::array<std::array<std::array<TH1F*, 2>, 2>, eEventHistograms_N> fEventHistograms{}; //! [ type - see enum EEventHistograms ][reco,sim][before, after event cuts]
+  } ec;                                                                                     // prepend "ec." for event counters
 
   // *) External histograms:
   struct ExternalHistograms {
-    TList* fExternalHistogramsList = NULL;
-    TH1D* fhistWeights = NULL;
+    TList* fExternalHistogramsList = nullptr;
+    TH1D* fhistWeights = nullptr;
   } ex;
 
   struct Observables {
-    TList* fObservablesList = NULL;
-    TProfile* fProfTwo[2][2] = {{NULL}}; //! [reco,sim][before, after event cuts]
+    TList* fObservablesList = nullptr;
+    std::array<std::array<TProfile*, 2>, 2> fProfTwo{}; //! [reco,sim][before, after event cuts]
   } obs;
 
   // *) Quality assurance histograms:
   struct QualityAssurance {
-    TList* fQualityAssuranceList = NULL; //!<! list to hold all qualityAssurance histograms
-    TH2F* fHistCentralityRecSim = NULL;
+    TList* fQualityAssuranceList = nullptr; //!<! list to hold all qualityAssurance histograms
+    TH2F* fHistCentralityRecSim = nullptr;
   } qa; // prepend "qa." for qa histograms
 
   // *) functions
@@ -552,6 +553,12 @@ struct MultiparticleCorrelationsMei // this name is used in lower-case format to
         break; // thisCent is already FT0C
     }
 
+    LOGF(info,
+         "centFT0C=%.6f  centFT0M=%.6f  centFV0A=%.6f",
+         collision.centFT0C(),
+         collision.centFT0M(),
+         collision.centFV0A());
+
     auto thisRefMult = collision.multTPC(); // use auto to determine the type
     switch (multiplicityTables) {
       case eMultTPC:
@@ -605,7 +612,7 @@ struct MultiparticleCorrelationsMei // this name is used in lower-case format to
         if (rm == eMC) {
           auto thisMCCollision = collision.mcCollision(); // corresponding MC truth simulated particle
           int multiplicitySim = static_cast<int>(tracks.size());
-          auto impactParameter = thisMCCollision.impactParameter() * 1e15;
+          auto impactParameter = thisMCCollision.impactParameter();
           LOGF(info,
                "Reco collision = %d, MC collision = %d, b = %f",
                collision.globalIndex(),