From 9b35b9fc49d1ad81e6aab8126a6932a49822ca8d Mon Sep 17 00:00:00 2001 From: ddobrigk Date: Sat, 16 May 2026 16:57:54 +0200 Subject: [PATCH 1/5] [Common] Add QA printouts for checking --- Common/Tasks/centralityStudypp.cxx | 38 ++++++++++++++++++++++-------- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/Common/Tasks/centralityStudypp.cxx b/Common/Tasks/centralityStudypp.cxx index ce1b1afb89e..d21e31f31f4 100644 --- a/Common/Tasks/centralityStudypp.cxx +++ b/Common/Tasks/centralityStudypp.cxx @@ -208,23 +208,41 @@ struct centralityStudypp { } if (doCentralityQA.value) { - // acquire vertex-Z equalization histograms if requested - LOGF(info, "Acquiring vertex-Z profiles for run %i", mRunNumber); + LOGF(info, "Acquiring centrality calibration for run %i", mRunNumber); TList* hCentralityObjects = nullptr; hCentralityObjects = ccdb->getForRun(pathCentrality, mRunNumber); - hCentralityFV0A = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFV0")); - hCentralityFT0A = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0A")); - hCentralityFT0C = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0C")); - hCentralityFT0M = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0")); - hCentralityFDDM = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFDD")); - hCentralityNTPV = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqNTracksPV")); - hCentralityNGlo = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqNGlobal")); - hCentralityMFT = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqMFT")); + hCentralityFV0A = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFV0")); + hCentralityFT0A = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0A")); + hCentralityFT0C = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0C")); + hCentralityFT0M = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFT0")); + hCentralityFDDM = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqFDD")); + hCentralityNTPV = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqNTracksPV")); + hCentralityNGlo = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqNGlobal")); + hCentralityMFT = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqMFT")); // won't capture null pointers -> explicitly check for those when attempting to evaluate + auto reportSuccess = [](TH1* a, TString name) { + if(!a){ + LOGF(info, "Calibration missing for %s", name.data()); + }else{ + LOGF(info, "Calibration loaded for %s", name.Data()) + } + }; + + reportSucess(hCentralityFV0A, "FV0A"); + reportSucess(hCentralityFT0A, "FT0A"); + reportSucess(hCentralityFT0C, "FT0C"); + reportSucess(hCentralityFT0M, "FT0M"); + reportSucess(hCentralityFDDM, "FDDM"); + reportSucess(hCentralityNTPV, "NTPV"); + reportSucess(hCentralityNGlo, "NGlobals"); + reportSucess(hCentralityMFT, "MFT"); + + LOGF(info, "Centrality calibration loading done.") } + histPath = std::format("Run_{}/", mRunNumber); histPointers.insert({histPath + "hCollisionSelection", histos.add((histPath + "hCollisionSelection").c_str(), "hCollisionSelection", {kTH1D, {{20, -0.5f, +19.5f}}})}); From 564175ed1a7cf8d17164abd0eb1afd4c7b74b784 Mon Sep 17 00:00:00 2001 From: ddobrigk Date: Sat, 16 May 2026 17:03:18 +0200 Subject: [PATCH 2/5] Update centralityStudypp.cxx --- Common/Tasks/centralityStudypp.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Common/Tasks/centralityStudypp.cxx b/Common/Tasks/centralityStudypp.cxx index d21e31f31f4..c1935225571 100644 --- a/Common/Tasks/centralityStudypp.cxx +++ b/Common/Tasks/centralityStudypp.cxx @@ -224,9 +224,9 @@ struct centralityStudypp { // won't capture null pointers -> explicitly check for those when attempting to evaluate auto reportSuccess = [](TH1* a, TString name) { if(!a){ - LOGF(info, "Calibration missing for %s", name.data()); + LOGF(info, "Calibration missing for %s", name.Data()); }else{ - LOGF(info, "Calibration loaded for %s", name.Data()) + LOGF(info, "Calibration loaded for %s", name.Data()); } }; From f34b8adb9e4579b9443994758cf8e81998511d60 Mon Sep 17 00:00:00 2001 From: ddobrigk Date: Sat, 16 May 2026 17:03:42 +0200 Subject: [PATCH 3/5] Update centralityStudypp.cxx --- Common/Tasks/centralityStudypp.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Common/Tasks/centralityStudypp.cxx b/Common/Tasks/centralityStudypp.cxx index c1935225571..925952c3339 100644 --- a/Common/Tasks/centralityStudypp.cxx +++ b/Common/Tasks/centralityStudypp.cxx @@ -239,7 +239,7 @@ struct centralityStudypp { reportSucess(hCentralityNGlo, "NGlobals"); reportSucess(hCentralityMFT, "MFT"); - LOGF(info, "Centrality calibration loading done.") + LOGF(info, "Centrality calibration loading done."); } From a3da58dfd18ee37ceace7eb346dd2b8cf9ca3cc5 Mon Sep 17 00:00:00 2001 From: ddobrigk Date: Sat, 16 May 2026 17:13:43 +0200 Subject: [PATCH 4/5] fix typos --- Common/Tasks/centralityStudypp.cxx | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/Common/Tasks/centralityStudypp.cxx b/Common/Tasks/centralityStudypp.cxx index 925952c3339..8d243a01875 100644 --- a/Common/Tasks/centralityStudypp.cxx +++ b/Common/Tasks/centralityStudypp.cxx @@ -222,27 +222,26 @@ struct centralityStudypp { hCentralityMFT = dynamic_cast(hCentralityObjects->FindObject("hCalibZeqMFT")); // won't capture null pointers -> explicitly check for those when attempting to evaluate - auto reportSuccess = [](TH1* a, TString name) { + auto reportSuccess = [](TH1* a, std::string name) { if(!a){ - LOGF(info, "Calibration missing for %s", name.Data()); + LOGF(info, "Calibration missing for %s", name); }else{ - LOGF(info, "Calibration loaded for %s", name.Data()); + LOGF(info, "Calibration loaded for %s", name); } }; - reportSucess(hCentralityFV0A, "FV0A"); - reportSucess(hCentralityFT0A, "FT0A"); - reportSucess(hCentralityFT0C, "FT0C"); - reportSucess(hCentralityFT0M, "FT0M"); - reportSucess(hCentralityFDDM, "FDDM"); - reportSucess(hCentralityNTPV, "NTPV"); - reportSucess(hCentralityNGlo, "NGlobals"); - reportSucess(hCentralityMFT, "MFT"); + reportSuccess(hCentralityFV0A, "FV0A"); + reportSuccess(hCentralityFT0A, "FT0A"); + reportSuccess(hCentralityFT0C, "FT0C"); + reportSuccess(hCentralityFT0M, "FT0M"); + reportSuccess(hCentralityFDDM, "FDDM"); + reportSuccess(hCentralityNTPV, "NTPV"); + reportSuccess(hCentralityNGlo, "NGlobals"); + reportSuccess(hCentralityMFT, "MFT"); LOGF(info, "Centrality calibration loading done."); } - histPath = std::format("Run_{}/", mRunNumber); histPointers.insert({histPath + "hCollisionSelection", histos.add((histPath + "hCollisionSelection").c_str(), "hCollisionSelection", {kTH1D, {{20, -0.5f, +19.5f}}})}); From 36c2e9c32800313243f82b1f94af88cf0cffda99 Mon Sep 17 00:00:00 2001 From: ALICE Builder Date: Sat, 16 May 2026 17:19:00 +0200 Subject: [PATCH 5/5] Please consider the following formatting changes (#509) --- Common/Tasks/centralityStudypp.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Common/Tasks/centralityStudypp.cxx b/Common/Tasks/centralityStudypp.cxx index 8d243a01875..20aa28e585a 100644 --- a/Common/Tasks/centralityStudypp.cxx +++ b/Common/Tasks/centralityStudypp.cxx @@ -223,12 +223,12 @@ struct centralityStudypp { // won't capture null pointers -> explicitly check for those when attempting to evaluate auto reportSuccess = [](TH1* a, std::string name) { - if(!a){ + if (!a) { LOGF(info, "Calibration missing for %s", name); - }else{ + } else { LOGF(info, "Calibration loaded for %s", name); } - }; + }; reportSuccess(hCentralityFV0A, "FV0A"); reportSuccess(hCentralityFT0A, "FT0A");