migrate to room db pt1/?

WARNING: does not compile as-is. tests are expected to fail.

[skip actions]

Signed-off-by: androidacy-user <opensource@androidacy.com>

Author: androidacy-user

app/build.gradle.kts

@@ -19,8 +19,6 @@ plugins {
     id("io.sentry.android.gradle")
 }
 
-// apply realm-android
-apply(plugin = "realm-android")
 val hasSentryConfig = File(rootProject.projectDir, "sentry.properties").exists()
 android {
     // functions to get git info: gitCommitHash, gitBranch, gitRemote
@@ -527,6 +525,9 @@ dependencies {
     // yes
     implementation("com.github.fingerprintjs:fingerprint-android:2.0.0")
 
+    // encryption for room
+    implementation("net.zetetic:android-database-sqlcipher:4.5.4")
+
     // room
     implementation("androidx.room:room-runtime:2.5.1")
 

app/proguard-rules.pro

@@ -195,6 +195,9 @@
 
 -keepclassmembers class org.apache.commons.compress.archivers.zip.* { *; }
 
+-keep,includedescriptorclasses class net.sqlcipher.** { *; }
+-keep,includedescriptorclasses interface net.sqlcipher.** { *; }
+
 # dontwarn
 -dontwarn android.os.SystemProperties
 -dontwarn android.view.ThreadedRenderer

app/src/main/assets/modulelistcache.db

@@ -28,6 +28,7 @@ import androidx.appcompat.widget.SearchView
 import androidx.cardview.widget.CardView
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
+import androidx.room.Room
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout.OnRefreshListener
 import com.fox2code.foxcompat.app.FoxActivity
@@ -54,11 +55,9 @@ import com.fox2code.mmm.utils.RuntimeUtils
 import com.fox2code.mmm.utils.SyncManager
 import com.fox2code.mmm.utils.io.net.Http.Companion.cleanDnsCache
 import com.fox2code.mmm.utils.io.net.Http.Companion.hasWebView
-import com.fox2code.mmm.utils.realm.ReposList
+import com.fox2code.mmm.utils.room.ReposListDatabase
 import com.google.android.material.bottomnavigation.BottomNavigationView
 import com.google.android.material.progressindicator.LinearProgressIndicator
-import io.realm.Realm
-import io.realm.RealmConfiguration
 import org.matomo.sdk.extra.TrackHelper
 import timber.log.Timber
 import java.sql.Timestamp
@@ -104,25 +103,24 @@ class MainActivity : FoxActivity(), OnRefreshListener, SearchView.OnQueryTextLis
         super.onCreate(savedInstanceState)
         TrackHelper.track().screen(this).with(MainApplication.INSTANCE!!.tracker)
         // track enabled repos
-        val realmConfig = RealmConfiguration.Builder().name("ReposList.realm")
-            .encryptionKey(MainApplication.INSTANCE!!.key)
-            .directory(MainApplication.INSTANCE!!.getDataDirWithPath("realms")).schemaVersion(1)
-            .allowQueriesOnUiThread(true).allowWritesOnUiThread(true).build()
-        val realm = Realm.getInstance(realmConfig)
+        val db = Room.databaseBuilder(
+            applicationContext,
+            ReposListDatabase::class.java,
+            "reposlist.db"
+        ).build()
+        val repoDao = db.reposListDao()
+        val repos = repoDao.getAll()
         val enabledRepos = StringBuilder()
-        realm.executeTransaction { r: Realm ->
-            for (r2 in r.where(
-                ReposList::class.java
-            ).equalTo("enabled", true).findAll()) {
-                enabledRepos.append(r2.url).append(":").append(r2.name).append(",")
+        for (repo in repos) {
+            if (repo.enabled) {
+                enabledRepos.append(repo.url).append(", ")
             }
         }
         if (enabledRepos.isNotEmpty()) {
-            enabledRepos.setLength(enabledRepos.length - 1)
+            enabledRepos.delete(enabledRepos.length - 2, enabledRepos.length)
+            TrackHelper.track().event("Enabled Repos", enabledRepos.toString())
+                .with(MainApplication.INSTANCE!!.tracker)
         }
-        TrackHelper.track().event("enabled_repos", enabledRepos.toString())
-            .with(MainApplication.INSTANCE!!.tracker)
-        realm.close()
         // hide this behind a buildconfig flag for now, but crash the app if it's not an official build and not debug
         if (BuildConfig.ENABLE_PROTECTION && !MainApplication.o && !BuildConfig.DEBUG) {
             throw RuntimeException("This is not an official build of AMM")

app/src/main/kotlin/com/fox2code/mmm/MainActivity.kt

@@ -18,10 +18,13 @@ import android.webkit.CookieManager
 import android.widget.CompoundButton
 import android.widget.Toast
 import androidx.fragment.app.FragmentActivity
+import androidx.room.Room
 import com.fox2code.foxcompat.app.FoxActivity
 import com.fox2code.mmm.databinding.ActivitySetupBinding
 import com.fox2code.mmm.utils.IntentHelper
 import com.fox2code.mmm.utils.realm.ReposList
+import com.fox2code.mmm.utils.room.ModuleListCacheDatabase
+import com.fox2code.mmm.utils.room.ReposListDatabase
 import com.fox2code.rosettax.LanguageActivity
 import com.fox2code.rosettax.LanguageSwitcher
 import com.google.android.material.bottomnavigation.BottomNavigationItemView
@@ -254,7 +257,7 @@ class SetupActivity : FoxActivity(), LanguageActivity {
                 r.close()
                 Timber.d("Realm transaction committed")
             }
-            editor.putString("last_shown_setup", "v2")
+            editor.putString("last_shown_setup", "v3")
             // Commit the changes
             editor.commit()
             // sleep to allow the realm transaction to finish
@@ -347,7 +350,18 @@ class SetupActivity : FoxActivity(), LanguageActivity {
 
     // creates the room database
     private fun createDatabases() {
+        val startTime = System.currentTimeMillis()
         val appContext = MainApplication.INSTANCE!!.applicationContext
+        Room.databaseBuilder(appContext, ReposListDatabase::class.java, "reposlist.db")
+            .createFromAsset("assets/reposlist.db")
+            .fallbackToDestructiveMigration()
+            .build()
+        // same for modulelistcache
+        Room.databaseBuilder(appContext, ModuleListCacheDatabase::class.java, "modulelistcache.db")
+            .createFromAsset("assets/modulelistcache.db")
+            .fallbackToDestructiveMigration()
+            .build()
+        Timber.d("Databases created in %s ms", System.currentTimeMillis() - startTime)
     }
 
     private fun createFiles() {

app/src/main/kotlin/com/fox2code/mmm/SetupActivity.kt

@@ -374,7 +374,7 @@ class BackgroundUpdateChecker(context: Context, workerParams: WorkerParameters)
         fun onMainActivityCreate(context: Context) {
             // Refuse to run if first_launch pref is not false
             if (MainApplication.getSharedPreferences("mmm")!!
-                    .getString("last_shown_setup", null) != "v2"
+                    .getString("last_shown_setup", null) != "v3"
             ) return
             // create notification channel group
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {

app/src/main/kotlin/com/fox2code/mmm/background/BackgroundUpdateChecker.kt

@@ -7,35 +7,34 @@
 package com.fox2code.mmm.manager
 
 import android.content.SharedPreferences
+import androidx.room.Room
 import com.fox2code.mmm.BuildConfig
 import com.fox2code.mmm.MainApplication
 import com.fox2code.mmm.installer.InstallerInitializer.Companion.peekModulesPath
 import com.fox2code.mmm.utils.SyncManager
 import com.fox2code.mmm.utils.io.PropUtils
-import com.fox2code.mmm.utils.realm.ModuleListCache
+import com.fox2code.mmm.utils.room.ModuleListCache
+import com.fox2code.mmm.utils.room.ModuleListCacheDao
+import com.fox2code.mmm.utils.room.ModuleListCacheDatabase
 import com.topjohnwu.superuser.Shell
 import com.topjohnwu.superuser.io.SuFile
 import com.topjohnwu.superuser.io.SuFileInputStream
-import io.realm.Realm
-import io.realm.RealmConfiguration
 import org.matomo.sdk.extra.TrackHelper
 import timber.log.Timber
 import java.io.BufferedReader
-import java.io.File
 import java.io.IOException
 import java.io.InputStreamReader
 import java.nio.charset.StandardCharsets
-import java.util.Objects
 
 class ModuleManager private constructor() : SyncManager() {
     private val moduleInfos: HashMap<String, LocalModuleInfo> = HashMap()
     private val bootPrefs: SharedPreferences = MainApplication.bootSharedPreferences!!
     private var updatableModuleCount = 0
 
     override fun scanInternal(updateListener: UpdateListener) {
-        // if last_shown_setup is not "v2", then refuse to continue
+        // if last_shown_setup is not "v3", then refuse to continue
         if (MainApplication.getSharedPreferences("mmm")!!
-                .getString("last_shown_setup", "") != "v2"
+                .getString("last_shown_setup", "") != "v3"
         ) {
             return
         }
@@ -65,60 +64,36 @@ class ModuleManager private constructor() : SyncManager() {
             for (module in modules) {
                 if (!SuFile("/data/adb/modules/$module").isDirectory) continue  // Ignore non directory files inside modules folder
                 var moduleInfo = moduleInfos[module]
-                // next, merge the module info with a record from ModuleListCache if it exists
-                var realmConfiguration: RealmConfiguration?
-                // get all dirs under the realms/repos/ dir under app's data dir
-                val cacheRoot =
-                    File(MainApplication.INSTANCE!!.getDataDirWithPath("realms/repos/").toURI())
-                var moduleListCache: ModuleListCache?
-                for (dir in Objects.requireNonNull<Array<File>>(cacheRoot.listFiles())) {
-                    if (dir.isDirectory) {
-                        // if the dir name matches the module name, use it as the cache dir
-                        val tempCacheRoot = File(dir.toString())
-                        Timber.d("Looking for cache in %s", tempCacheRoot)
-                        realmConfiguration =
-                            RealmConfiguration.Builder().name("ModuleListCache.realm")
-                                .encryptionKey(MainApplication.INSTANCE!!.key).schemaVersion(1)
-                                .deleteRealmIfMigrationNeeded().allowWritesOnUiThread(true)
-                                .allowQueriesOnUiThread(true).directory(tempCacheRoot).build()
-                        val realm = Realm.getInstance(realmConfiguration!!)
-                        Timber.d(
-                            "Looking for cache for %s out of %d", module, realm.where(
-                                ModuleListCache::class.java
-                            ).count()
-                        )
-                        moduleListCache =
-                            realm.where(ModuleListCache::class.java).equalTo("codename", module)
-                                .findFirst()
-                        Timber.d("Found cache for %s", module)
-                        // get module info from cache
-                        if (moduleInfo == null) {
-                            moduleInfo = LocalModuleInfo(module)
-                        }
-                        if (moduleListCache != null) {
-                            moduleInfo.name =
-                                if (moduleListCache.name != "") moduleListCache.name else module
-                            moduleInfo.description =
-                                if (moduleListCache.description != "") moduleListCache.description else moduleInfo.description
-                            moduleInfo.author =
-                                if (moduleListCache.author != "") moduleListCache.author else moduleInfo.author
-                            moduleInfo.safe = moduleListCache.isSafe == true
-                            moduleInfo.support =
-                                if (moduleListCache.support != "") moduleListCache.support else null
-                            moduleInfo.donate =
-                                if (moduleListCache.donate != "") moduleListCache.donate else null
-                            moduleInfo.flags = moduleInfo.flags or FLAG_MM_REMOTE_MODULE
-                            moduleInfos[module] = moduleInfo
-                        }
-                        realm.close()
-                        break
-                    }
-                }
+                // next, merge the module info with a record from ModuleListCache room db if it exists
+                // initialize modulelistcache db
+                // DO NOT USE REALM ANYMORE
+                val db = Room.databaseBuilder(
+                    MainApplication.INSTANCE!!,
+                    ModuleListCacheDatabase::class.java,
+                    "ModuleListCache"
+                ).build()
+                // get module info from cache
+                val moduleListCacheDao: ModuleListCacheDao = db.moduleListCacheDao()
+                Timber.d("Found cache for %s", module)
+                // get module info from cache
                 if (moduleInfo == null) {
                     moduleInfo = LocalModuleInfo(module)
+                }
+                if (moduleListCacheDao.exists(module)) {
+                    val moduleListCache: ModuleListCache = moduleListCacheDao.getByCodename(module)
+                    moduleInfo.name =
+                        if (moduleListCache.name != "") moduleListCache.name else module
+                    moduleInfo.description =
+                        if (moduleListCache.description != "") moduleListCache.description else moduleInfo.description
+                    moduleInfo.author =
+                        if (moduleListCache.author != "") moduleListCache.author else moduleInfo.author
+                    moduleInfo.safe = moduleListCache.safe == true
+                    moduleInfo.support =
+                        if (moduleListCache.support != "") moduleListCache.support else null
+                    moduleInfo.donate =
+                        if (moduleListCache.donate != "") moduleListCache.donate else null
+                    moduleInfo.flags = moduleInfo.flags or FLAG_MM_REMOTE_MODULE
                     moduleInfos[module] = moduleInfo
-                    // This should not really happen, but let's handles theses cases anyway
-                    moduleInfo.flags = moduleInfo.flags or ModuleInfo.FLAG_MODULE_UPDATING_ONLY
                 }
                 moduleInfo.flags = moduleInfo.flags and FLAGS_RESET_UPDATE.inv()
                 if (SuFile("/data/adb/modules/$module/disable").exists()) {
@@ -131,8 +106,7 @@ class ModuleManager private constructor() : SyncManager() {
                     moduleInfo.flags = moduleInfo.flags or ModuleInfo.FLAG_MODULE_UNINSTALLING
                 }
                 if (firstScan && !needFallback && SuFile(
-                        modulesPath,
-                        module
+                        modulesPath, module
                     ).exists() || bootPrefs.getBoolean("module_" + moduleInfo.id + "_active", false)
                 ) {
                     moduleInfo.flags = moduleInfo.flags or ModuleInfo.FLAG_MODULE_ACTIVE
@@ -152,9 +126,7 @@ class ModuleManager private constructor() : SyncManager() {
                 }
                 try {
                     PropUtils.readProperties(
-                        moduleInfo,
-                        "/data/adb/modules/$module/module.prop",
-                        true
+                        moduleInfo, "/data/adb/modules/$module/module.prop", true
                     )
                 } catch (e: Exception) {
                     if (BuildConfig.DEBUG) Timber.d(e)
@@ -186,9 +158,7 @@ class ModuleManager private constructor() : SyncManager() {
                 moduleInfo.flags = moduleInfo.flags or ModuleInfo.FLAG_MODULE_UPDATING
                 try {
                     PropUtils.readProperties(
-                        moduleInfo,
-                        "/data/adb/modules_update/$module/module.prop",
-                        true
+                        moduleInfo, "/data/adb/modules_update/$module/module.prop", true
                     )
                 } catch (e: Exception) {
                     if (BuildConfig.DEBUG) Timber.d(e)