From c5228690d7d3b0f4f58001a5d31080b83062dee9 Mon Sep 17 00:00:00 2001 From: Dien-Hoa Date: Mon, 20 Apr 2026 21:43:22 -0400 Subject: [PATCH 1/2] explicit error message when exporting with relative import --- nbdev/maker.py | 2 +- nbs/api/02_maker.ipynb | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/nbdev/maker.py b/nbdev/maker.py index 3b8b17798..78e886210 100644 --- a/nbdev/maker.py +++ b/nbdev/maker.py @@ -111,7 +111,7 @@ def make_code_cells(*ss): return dict2nb({'cells':L(ss).map(mk_cell)}).cells # %% ../nbs/api/02_maker.ipynb #a2546836 def relative_import(name, fname, level=0): "Convert a module `name` to a name relative to `fname`" - assert not level + if level: raise ValueError(f"nbdev export does not support relative imports: module={name}, export_path={fname}") sname = name.replace('.','/') if not(os.path.commonpath([sname,fname])): return name rel = os.path.relpath(sname, fname) diff --git a/nbs/api/02_maker.ipynb b/nbs/api/02_maker.ipynb index 31ed741ff..076ae0b3d 100644 --- a/nbs/api/02_maker.ipynb +++ b/nbs/api/02_maker.ipynb @@ -350,7 +350,7 @@ "#| export\n", "def relative_import(name, fname, level=0):\n", " \"Convert a module `name` to a name relative to `fname`\"\n", - " assert not level\n", + " if level: raise ValueError(f\"nbdev export does not support relative imports: module={name}, export_path={fname}\")\n", " sname = name.replace('.','/')\n", " if not(os.path.commonpath([sname,fname])): return name\n", " rel = os.path.relpath(sname, fname)\n", @@ -817,6 +817,9 @@ } ], "metadata": { + "language_info": { + "name": "python" + }, "solveit_dialog_mode": "learning", "solveit_ver": 2 }, From 77a063612978665cebe6adb2cdeb97d1a75929e1 Mon Sep 17 00:00:00 2001 From: Dien-Hoa Date: Mon, 20 Apr 2026 22:10:38 -0400 Subject: [PATCH 2/2] remove metadata diff --- nbs/api/02_maker.ipynb | 3 --- 1 file changed, 3 deletions(-) diff --git a/nbs/api/02_maker.ipynb b/nbs/api/02_maker.ipynb index 076ae0b3d..ba88752f5 100644 --- a/nbs/api/02_maker.ipynb +++ b/nbs/api/02_maker.ipynb @@ -817,9 +817,6 @@ } ], "metadata": { - "language_info": { - "name": "python" - }, "solveit_dialog_mode": "learning", "solveit_ver": 2 },