fix(android-old-arch): reset root views to fix View ID conflict

This would have an impact on old arch, Android, RN >= 0.77, notably with suspend/resume installMode

Author: Minishlink

android/app/proguard-rules.pro

@@ -19,6 +19,7 @@
 # Invoked via reflection, when setting js bundle.
 -keepclassmembers class com.facebook.react.ReactInstanceManager {
     private final ** mBundleLoader;
+    private ** mAttachedReactRoots;
 }
 -keepclassmembers class com.facebook.react.runtime.ReactHostImpl {
     private final ** mReactHostDelegate;
@@ -27,5 +28,13 @@
 -keep interface com.facebook.react.runtime.ReactHostDelegate { *; }
 -keep class * implements com.facebook.react.runtime.ReactHostDelegate { *; }
 
+# Invoked via reflection, when resetting root views.
+-keepclassmembers interface com.facebook.react.ReactRoot {
+    public ** getRootViewGroup();
+}
+-keepclassmembers class * implements com.facebook.react.ReactRoot {
+    public ** getRootViewGroup();
+}
+
 # Can't find referenced class org.bouncycastle.**
 -dontwarn com.nimbusds.jose.**

android/app/src/main/java/com/appzung/codepush/react/CodePushNativeModule.java

@@ -7,6 +7,7 @@
 import android.os.Looper;
 import android.view.Choreographer;
 import android.view.View;
+import android.view.ViewGroup;
 
 import androidx.annotation.OptIn;
 
@@ -268,6 +269,7 @@ private void loadBundle() {
                     @Override
                     public void run() {
                         try {
+                            resetReactRootViews(instanceManager);
                             instanceManager.recreateReactContextInBackground();
                             mCodePush.initializeUpdateAfterRestart();
                         } catch (Exception e) {
@@ -315,6 +317,26 @@ private void clearLifecycleEventListener() {
         }
     }
 
+    private void resetReactRootViews(ReactInstanceManager instanceManager) throws NoSuchFieldException, IllegalAccessException {
+        Field mAttachedReactRootsField = instanceManager.getClass().getDeclaredField("mAttachedReactRoots");
+        mAttachedReactRootsField.setAccessible(true);
+        java.util.Set<?> mAttachedReactRoots = (java.util.Set<?>) mAttachedReactRootsField.get(instanceManager);
+        if (mAttachedReactRoots != null) {
+            for (Object reactRoot : mAttachedReactRoots) {
+                try {
+                    Method getRootViewGroupMethod = reactRoot.getClass().getMethod("getRootViewGroup");
+                    ViewGroup rootViewGroup = (ViewGroup) getRootViewGroupMethod.invoke(reactRoot);
+                    if (rootViewGroup != null) {
+                        rootViewGroup.removeAllViews();
+                        rootViewGroup.setId(View.NO_ID);
+                    }
+                } catch (Exception e) {
+                    CodePushUtils.log("Failed to reset root view: " + e.getMessage());
+                }
+            }
+        }
+    }
+
     // Use reflection to find the ReactInstanceManager. See #556 for a proposal for a less brittle way to approach this.
     private ReactInstanceManager resolveInstanceManager() throws NoSuchFieldException, IllegalAccessException {
         ReactInstanceManager instanceManager = CodePush.getReactInstanceManager();