zonefs: d_splice_alias() will do the right thing on ERR_PTR() inode

Al Viro · Al Viro · commit 00488aa21150 · 2023-12-20T12:08:03.000-05:00
Acked-by: Damien Le Moal &lt;dlemoal@kernel.org&gt;
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
@@ -747,8 +747,6 @@ static struct dentry *zonefs_lookup(struct inode *dir, struct dentry *dentry,
 		inode = zonefs_get_dir_inode(dir, dentry);
 	else
 		inode = zonefs_get_file_inode(dir, dentry);
-	if (IS_ERR(inode))
-		return ERR_CAST(inode);
 
 	return d_splice_alias(inode, dentry);
 }

Original file line number	Diff line number	Diff line change
`@@ -747,8 +747,6 @@ static struct dentry zonefs_lookup(struct inode dir, struct dentry *dentry,`
`747`	`747`	`inode = zonefs_get_dir_inode(dir, dentry);`
`748`	`748`	`else`
`749`	`749`	`inode = zonefs_get_file_inode(dir, dentry);`
`750`		`- if (IS_ERR(inode))`
`751`		`- return ERR_CAST(inode);`
`752`	`750`
`753`	`751`	`return d_splice_alias(inode, dentry);`
`754`	`752`	`}`