drm: apple: iomfb: Clear non-visible planes

jannau · jannau · commit 014fbe2ff4ce · 2025-01-18T11:35:04.000+01:00
Fixes failed DCP swap validity checks and subsequent DCP crashes. Fixes: 5536a93 ("drm: apple: refactor apple_plane_atomic_check") Signed-off-by: Janne Grunau <j@jannau.net>
diff --git a/drivers/gpu/drm/apple/iomfb_template.c b/drivers/gpu/drm/apple/iomfb_template.c
@@ -1343,7 +1343,7 @@ void DCP_FW_NAME(iomfb_flush)(struct apple_dcp *dcp, struct drm_crtc *crtc, stru
 			drm_framebuffer_get(old_state->fb);
 		}
 
-		if (!new_state->fb) {
+		if (!new_state->fb || !new_state->visible) {
 			continue;
 		}
 		req->surf_null[l] = false;

Original file line number	Diff line number	Diff line change
`@@ -1343,7 +1343,7 @@ void DCP_FW_NAME(iomfb_flush)(struct apple_dcp dcp, struct drm_crtc crtc, stru`
`1343`	`1343`	`drm_framebuffer_get(old_state->fb);`
`1344`	`1344`	`}`
`1345`	`1345`
`1346`		`- if (!new_state->fb) {`
	`1346`	`+ if (!new_state->fb \|\| !new_state->visible) {`
`1347`	`1347`	`continue;`
`1348`	`1348`	`}`
`1349`	`1349`	`req->surf_null[l] = false;`