Skip to content

Commit 017c73a

Browse files
Zhihao Chengrichardweinberger
authored andcommitted
ubi: Refuse attaching if mtd's erasesize is 0
There exists mtd devices with zero erasesize, which will trigger a divide-by-zero exception while attaching ubi device. Fix it by refusing attaching if mtd's erasesize is 0. Fixes: 801c135 ("UBI: Unsorted Block Images") Reported-by: Yu Hao <yhao016@ucr.edu> Link: https://lore.kernel.org/lkml/977347543.226888.1682011999468.JavaMail.zimbra@nod.at/T/ Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent 4a0fc73 commit 017c73a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/mtd/ubi/build.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -894,6 +894,13 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
894894
return -EINVAL;
895895
}
896896

897+
/* UBI cannot work on flashes with zero erasesize. */
898+
if (!mtd->erasesize) {
899+
pr_err("ubi: refuse attaching mtd%d - zero erasesize flash is not supported\n",
900+
mtd->index);
901+
return -EINVAL;
902+
}
903+
897904
if (ubi_num == UBI_DEV_NUM_AUTO) {
898905
/* Search for an empty slot in the @ubi_devices array */
899906
for (ubi_num = 0; ubi_num < UBI_MAX_DEVICES; ubi_num++)

0 commit comments

Comments
 (0)