Skip to content

Commit 01ecf7a

Browse files
committed
tracing: Add warnings for unused tracepoints for modules
If a modules has TRACE_EVENT() but does not use it, add a warning about it at build time. Currently, the build must be made by adding "UT=1" to the make command line in order for this to trigger. Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Nicolas Schier <nicolas.schier@linux.dev> Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Link: https://lore.kernel.org/20251022004453.422000794@kernel.org Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent eec3516 commit 01ecf7a

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

scripts/Makefile.modfinal

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ ccflags-remove-y := $(CC_FLAGS_CFI)
2828
.module-common.o: $(srctree)/scripts/module-common.c FORCE
2929
$(call if_changed_rule,cc_o_c)
3030

31+
ifneq ($(WARN_ON_UNUSED_TRACEPOINTS),)
32+
cmd_check_tracepoint = $(objtree)/scripts/tracepoint-update --module $<;
33+
endif
34+
3135
quiet_cmd_ld_ko_o = LD [M] $@
3236
cmd_ld_ko_o = \
3337
$(LD) -r $(KBUILD_LDFLAGS) \
@@ -57,6 +61,7 @@ if_changed_except = $(if $(call newer_prereqs_except,$(2))$(cmd-check), \
5761
ifdef CONFIG_DEBUG_INFO_BTF_MODULES
5862
+$(if $(newer-prereqs),$(call cmd,btf_ko))
5963
endif
64+
+$(call cmd,check_tracepoint)
6065

6166
targets += $(modules:%.o=%.ko) $(modules:%.o=%.mod.o) .module-common.o
6267

0 commit comments

Comments
 (0)