virtio_blk: remove duplicate check if queue is broken in virtblk_done

lrq-max · axboe · commit 04036d49c44b · 2024-01-15T09:33:41.000-07:00
virtqueue_enable_cb() will call virtqueue_poll() which will check if
queue is broken at beginning, so remove the virtqueue_is_broken() call

Acked-by: Jason Wang &lt;jasowang@redhat.com&gt;
Signed-off-by: Li RongQing &lt;lirongqing@baidu.com&gt;
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
@@ -367,8 +367,6 @@ static void virtblk_done(struct virtqueue *vq)
 				blk_mq_complete_request(req);
 			req_done = true;
 		}
-		if (unlikely(virtqueue_is_broken(vq)))
-			break;
 	} while (!virtqueue_enable_cb(vq));
 
 	/* In case queue is stopped waiting for more buffers. */

Original file line number	Diff line number	Diff line change
`@@ -367,8 +367,6 @@ static void virtblk_done(struct virtqueue *vq)`
`367`	`367`	`blk_mq_complete_request(req);`
`368`	`368`	`req_done = true;`
`369`	`369`	`}`
`370`		`- if (unlikely(virtqueue_is_broken(vq)))`
`371`		`- break;`
`372`	`370`	`} while (!virtqueue_enable_cb(vq));`
`373`	`371`
`374`	`372`	`/* In case queue is stopped waiting for more buffers. */`