Skip to content

Commit 04a8ff1

Browse files
kromlibroonie
authored andcommitted
spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
Remove incorrect checks on cqspi->rx_chan that cause driver breakage during failure cleanup. Ensure proper resource freeing on the success path when operating in cqspi->use_direct_mode, preventing leaks and improving stability. Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/89765a2b94f047ded4f14babaefb7ef92ba07cb2.1751274389.git.khairul.anuar.romli@altera.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 4ec24e9 commit 04a8ff1

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/spi/spi-cadence-quadspi.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
19601960

19611961
pm_runtime_enable(dev);
19621962

1963-
if (cqspi->rx_chan) {
1964-
dma_release_channel(cqspi->rx_chan);
1965-
goto probe_setup_failed;
1966-
}
1967-
19681963
pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
19691964
pm_runtime_use_autosuspend(dev);
19701965
pm_runtime_get_noresume(dev);

0 commit comments

Comments
 (0)