usb: gadget: f_uac2: Fix incorrect setting of bNumEndpoints

Prashanth K · gregkh · commit 057bd54dfcf6 · 2024-12-23T18:50:28.000+01:00
Currently afunc_bind sets std_ac_if_desc.bNumEndpoints to 1 if controls (mute/volume) are enabled. During next afunc_bind call, bNumEndpoints would be unchanged and incorrectly set to 1 even if the controls aren't enabled. Fix this by resetting the value of bNumEndpoints to 0 on every afunc_bind call. Fixes: eaf6cbe ("usb: gadget: f_uac2: add volume and mute support") Cc: stable <stable@kernel.org> Signed-off-by: Prashanth K <quic_prashk@quicinc.com> Link: https://lore.kernel.org/r/20241211115915.159864-1-quic_prashk@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
@@ -1185,6 +1185,7 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn)
 		uac2->as_in_alt = 0;
 	}
 
+	std_ac_if_desc.bNumEndpoints = 0;
 	if (FUOUT_EN(uac2_opts) || FUIN_EN(uac2_opts)) {
 		uac2->int_ep = usb_ep_autoconfig(gadget, &fs_ep_int_desc);
 		if (!uac2->int_ep) {

Original file line number	Diff line number	Diff line change
`@@ -1185,6 +1185,7 @@ afunc_bind(struct usb_configuration cfg, struct usb_function fn)`
`1185`	`1185`	`uac2->as_in_alt = 0;`
`1186`	`1186`	`}`
`1187`	`1187`
	`1188`	`+ std_ac_if_desc.bNumEndpoints = 0;`
`1188`	`1189`	`if (FUOUT_EN(uac2_opts) \|\| FUIN_EN(uac2_opts)) {`
`1189`	`1190`	`uac2->int_ep = usb_ep_autoconfig(gadget, &fs_ep_int_desc);`
`1190`	`1191`	`if (!uac2->int_ep) {`