gfs2: Fix GLF_INVALIDATE_IN_PROGRESS flag clearing in do_xmote

Andreas Gruenbacher · Andreas Gruenbacher · commit 061df28b82af · 2025-09-12T12:02:38.000+02:00
Commit 865cc3e ("gfs2: fix a deadlock on withdraw-during-mount") added a statement to do_xmote() to clear the GLF_INVALIDATE_IN_PROGRESS flag a second time after it has already been cleared. Fix that. Fixes: 865cc3e ("gfs2: fix a deadlock on withdraw-during-mount") Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: Andrew Price <anprice@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
@@ -797,8 +797,6 @@ __acquires(&gl->gl_lockref.lock)
 			gl->gl_lockref.count++;
 			gfs2_glock_queue_work(gl, GL_GLOCK_DFT_HOLD);
 			return;
-		} else {
-			clear_bit(GLF_INVALIDATE_IN_PROGRESS, &gl->gl_flags);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -797,8 +797,6 @@ __acquires(&gl->gl_lockref.lock)`
`797`	`797`	`gl->gl_lockref.count++;`
`798`	`798`	`gfs2_glock_queue_work(gl, GL_GLOCK_DFT_HOLD);`
`799`	`799`	`return;`
`800`		`- } else {`
`801`		`- clear_bit(GLF_INVALIDATE_IN_PROGRESS, &gl->gl_flags);`
`802`	`800`	`}`
`803`	`801`	`}`
`804`	`802`