Skip to content

Commit 0697496

Browse files
author
Kent Overstreet
committed
bcachefs: Fix iterator leak in may_delete_deleted_inode()
may_delete_deleted_inode() was returning without exiting a btree iterator, eventually causing propagate_key_to_snaphot_leaves() to go into an infinite loop hitting btree_trans_too_many_iters(). Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
1 parent 006ccc3 commit 0697496

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/bcachefs/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,7 @@ static int may_delete_deleted_inode(struct btree_trans *trans,
11341134
* unlinked inodes in the snapshot leaves:
11351135
*/
11361136
*need_another_pass = true;
1137-
return 0;
1137+
goto out;
11381138
}
11391139

11401140
ret = 1;

0 commit comments

Comments
 (0)