Skip to content

Commit 072cd5f

Browse files
fenglinw-qcomlag-linaro
authored andcommitted
leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM
The PWM signal from the LPG channel can be routed to PMIC GPIOs with proper GPIO configuration, and it is not necessary to enable the TRILED channel in that case. This also applies to the LPG channels that mapped to TRILED channels. Additionally, enabling the TRILED channel unnecessarily would cause a voltage increase in its power supply. Hence remove it. Fixes: 24e2d05 ("leds: Add driver for Qualcomm LPG") Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Link: https://patch.msgid.link/20251119-lpg_triled_fix-v3-2-84b6dbdc774a@oss.qualcomm.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 5d390e7 commit 072cd5f

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/leds/rgb/leds-qcom-lpg.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/*
33
* Copyright (c) 2017-2022 Linaro Ltd
44
* Copyright (c) 2010-2012, The Linux Foundation. All rights reserved.
5-
* Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved.
5+
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
66
*/
77
#include <linux/bits.h>
88
#include <linux/bitfield.h>
@@ -1247,8 +1247,6 @@ static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
12471247

12481248
lpg_apply(chan);
12491249

1250-
triled_set(lpg, chan->triled_mask, chan->enabled ? chan->triled_mask : 0);
1251-
12521250
out_unlock:
12531251
mutex_unlock(&lpg->lock);
12541252

0 commit comments

Comments
 (0)