drm/amdgpu: fix ras err_data null pointer issue in amdgpu_ras.c

Yang Wang · alexdeucher · commit 07ee43faeb7e · 2023-11-17T00:51:58.000-05:00
fix ras err_data null pointer issue in amdgpu_ras.c Fixes: 8cc0f56 ("drm/amdgpu: Support multiple error query modes") Signed-off-by: Yang Wang <kevinyang.wang@amd.com> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1188,7 +1188,7 @@ static int amdgpu_ras_query_error_status_helper(struct amdgpu_device *adev,
 			}
 
 			if (block_obj->hw_ops->query_ras_error_count)
-				block_obj->hw_ops->query_ras_error_count(adev, &err_data);
+				block_obj->hw_ops->query_ras_error_count(adev, err_data);
 
 			if ((info->head.block == AMDGPU_RAS_BLOCK__SDMA) ||
 			    (info->head.block == AMDGPU_RAS_BLOCK__GFX) ||

Original file line number	Diff line number	Diff line change
`@@ -1188,7 +1188,7 @@ static int amdgpu_ras_query_error_status_helper(struct amdgpu_device *adev,`
`1188`	`1188`	`}`
`1189`	`1189`
`1190`	`1190`	`if (block_obj->hw_ops->query_ras_error_count)`
`1191`		`- block_obj->hw_ops->query_ras_error_count(adev, &err_data);`
	`1191`	`+ block_obj->hw_ops->query_ras_error_count(adev, err_data);`
`1192`	`1192`
`1193`	`1193`	`if ((info->head.block == AMDGPU_RAS_BLOCK__SDMA) \|\|`
`1194`	`1194`	`(info->head.block == AMDGPU_RAS_BLOCK__GFX) \|\|`