um: Remove double zero check

Shaojie Dong · jmberg-intel · commit 0b0ad2541d8e · 2024-11-07T17:34:03.000+01:00
free_pages() performs a parameter null check inside therefore remove double zero check here. Signed-off-by: Shaojie Dong <quic_shaojied@quicinc.com> Link: https://patch.msgid.link/20241025-upstream_branch-v5-1-b8998beb2c64@quicinc.com Signed-off-by: Johannes Berg <johannes.berg@intel.com>
diff --git a/arch/um/kernel/skas/mmu.c b/arch/um/kernel/skas/mmu.c
@@ -46,8 +46,7 @@ int init_new_context(struct task_struct *task, struct mm_struct *mm)
 	return 0;
 
  out_free:
-	if (new_id->stack != 0)
-		free_pages(new_id->stack, ilog2(STUB_DATA_PAGES));
+	free_pages(new_id->stack, ilog2(STUB_DATA_PAGES));
  out:
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,7 @@ int init_new_context(struct task_struct task, struct mm_struct mm)`
`46`	`46`	`return 0;`
`47`	`47`
`48`	`48`	`out_free:`
`49`		`- if (new_id->stack != 0)`
`50`		`- free_pages(new_id->stack, ilog2(STUB_DATA_PAGES));`
	`49`	`+ free_pages(new_id->stack, ilog2(STUB_DATA_PAGES));`
`51`	`50`	`out:`
`52`	`51`	`return ret;`
`53`	`52`	`}`