Skip to content

Commit 0b48de0

Browse files
vsyrjalagregkh
authored andcommitted
drm/i915/dsi: Fix off by one in BXT_MIPI_TRANS_VTOTAL
commit c464ce6 upstream. BXT_MIPI_TRANS_VTOTAL must be programmed with vtotal-1 instead of vtotal. Make it so. Cc: stable@vger.kernel.org Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250314150136.22564-1-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com> (cherry picked from commit 7b3685c) Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b4b6cfb commit 0b48de0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/vlv_dsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
10601060
BXT_MIPI_TRANS_VACTIVE(port));
10611061
adjusted_mode->crtc_vtotal =
10621062
intel_de_read(display,
1063-
BXT_MIPI_TRANS_VTOTAL(port));
1063+
BXT_MIPI_TRANS_VTOTAL(port)) + 1;
10641064

10651065
hactive = adjusted_mode->crtc_hdisplay;
10661066
hfp = intel_de_read(display, MIPI_HFP_COUNT(display, port));
@@ -1265,7 +1265,7 @@ static void set_dsi_timings(struct intel_encoder *encoder,
12651265
intel_de_write(display, BXT_MIPI_TRANS_VACTIVE(port),
12661266
adjusted_mode->crtc_vdisplay);
12671267
intel_de_write(display, BXT_MIPI_TRANS_VTOTAL(port),
1268-
adjusted_mode->crtc_vtotal);
1268+
adjusted_mode->crtc_vtotal - 1);
12691269
}
12701270

12711271
intel_de_write(display, MIPI_HACTIVE_AREA_COUNT(display, port),

0 commit comments

Comments
 (0)