Skip to content

Commit 0b873de

Browse files
Mike SnitzerTrond Myklebust
authored andcommitted
nfs/localio: remove 61 byte hole from needless ____cacheline_aligned
struct nfs_local_kiocb used ____cacheline_aligned on its iters[] array and as the structure evolved it caused a 61 byte hole to form. Fix this by removing ____cacheline_aligned and reordering iters[] before iter_is_dio_aligned[]. Fixes: 6a218b9 ("nfs/localio: do not issue misaligned DIO out-of-order") Signed-off-by: Mike Snitzer <snitzer@kernel.org> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent f50d032 commit 0b873de

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/nfs/localio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ struct nfs_local_kiocb {
4343
size_t end_len;
4444
short int end_iter_index;
4545
atomic_t n_iters;
46+
struct iov_iter iters[NFSLOCAL_MAX_IOS];
4647
bool iter_is_dio_aligned[NFSLOCAL_MAX_IOS];
47-
struct iov_iter iters[NFSLOCAL_MAX_IOS] ____cacheline_aligned;
4848
/* End mostly DIO-specific members */
4949
};
5050

0 commit comments

Comments
 (0)