net: bcmasp: Fix error code in probe()

Dan Carpenter · kuba-moo · commit 0c754d9d86ff · 2024-07-05T17:13:57.000-07:00
Return an error code if bcmasp_interface_create() fails. Don't return success. Fixes: 490cb41 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> Reviewed-by: Justin Chen <justin.chen@broadcom.com> Link: https://patch.msgid.link/ZoWKBkHH9D1fqV4r@stanley.mountain Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
@@ -1380,6 +1380,7 @@ static int bcmasp_probe(struct platform_device *pdev)
 			dev_err(dev, "Cannot create eth interface %d\n", i);
 			bcmasp_remove_intfs(priv);
 			of_node_put(intf_node);
+			ret = -ENOMEM;
 			goto of_put_exit;
 		}
 		list_add_tail(&intf->list, &priv->intfs);

Original file line number	Diff line number	Diff line change
`@@ -1380,6 +1380,7 @@ static int bcmasp_probe(struct platform_device *pdev)`
`1380`	`1380`	`dev_err(dev, "Cannot create eth interface %d\n", i);`
`1381`	`1381`	`bcmasp_remove_intfs(priv);`
`1382`	`1382`	`of_node_put(intf_node);`
	`1383`	`+ ret = -ENOMEM;`
`1383`	`1384`	`goto of_put_exit;`
`1384`	`1385`	`}`
`1385`	`1386`	`list_add_tail(&intf->list, &priv->intfs);`