ufs_rename(): fix bogus argument of folio_release_kmap()

Al Viro · Al Viro · commit 0d0b8646a66d · 2024-10-02T00:05:09.000-04:00
new_dir does *NOT* point into dir_folio - it's an inode, not a pointer to ufs directory entry. Fixes: 516b97c "ufs: Convert directory handling to kmap_local" Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c
@@ -307,7 +307,7 @@ static int ufs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
 		if (old_dir != new_dir)
 			ufs_set_link(old_inode, dir_de, dir_folio, new_dir, 0);
 		else
-			folio_release_kmap(dir_folio, new_dir);
+			folio_release_kmap(dir_folio, dir_de);
 		inode_dec_link_count(old_dir);
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ static int ufs_rename(struct mnt_idmap idmap, struct inode old_dir,`
`307`	`307`	`if (old_dir != new_dir)`
`308`	`308`	`ufs_set_link(old_inode, dir_de, dir_folio, new_dir, 0);`
`309`	`309`	`else`
`310`		`- folio_release_kmap(dir_folio, new_dir);`
	`310`	`+ folio_release_kmap(dir_folio, dir_de);`
`311`	`311`	`inode_dec_link_count(old_dir);`
`312`	`312`	`}`
`313`	`313`	`return 0;`