Skip to content

Commit 0d28064

Browse files
ahunter6gregkh
authored andcommitted
i3c: mipi-i3c-hci: Restart DMA ring correctly after dequeue abort
commit b6d5864 upstream. The DMA dequeue path attempts to restart the ring after aborting an in-flight transfer, but the current sequence is incomplete. The controller must be brought out of the aborted state and the ring control registers must be programmed in the correct order: first clearing ABORT, then re-enabling the ring and asserting RUN_STOP to resume operation. Add the missing controller resume step and update the ring control writes so that the ring is restarted using the proper sequence. Fixes: 9ad9a52 ("i3c/master: introduce the mipi-i3c-hci driver") Cc: stable@vger.kernel.org Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260306072451.11131-11-adrian.hunter@intel.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d6e90df commit 0d28064

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • drivers/i3c/master/mipi-i3c-hci

drivers/i3c/master/mipi-i3c-hci/dma.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,9 @@ static bool hci_dma_dequeue_xfer(struct i3c_hci *hci,
528528
}
529529

530530
/* restart the ring */
531+
mipi_i3c_hci_resume(hci);
531532
rh_reg_write(RING_CONTROL, RING_CTRL_ENABLE);
533+
rh_reg_write(RING_CONTROL, RING_CTRL_ENABLE | RING_CTRL_RUN_STOP);
532534

533535
return did_unqueue;
534536
}

0 commit comments

Comments
 (0)