Skip to content

Commit 0e8913b

Browse files
eilnjannau
authored andcommitted
media: apple: isp: Better document info struct fields
"Document". I also counted wrong multiple times. Signed-off-by: Eileen Yoon <eyn@gmx.com>
1 parent 3a902bb commit 0e8913b

1 file changed

Lines changed: 55 additions & 9 deletions

File tree

drivers/media/platform/apple/isp/isp-cmd.h

Lines changed: 55 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -202,19 +202,53 @@ static_assert(sizeof(struct cmd_ch_stop) == 0xc);
202202
struct cmd_ch_info {
203203
u64 opcode;
204204
u32 chan;
205-
u32 unk_c;
206-
u32 unk_10[4];
205+
u32 unk_c; // 0x7da0001, 0x7db0001
206+
u32 unk_10; // 0x300ac, 0x5006d
207+
u32 unk_14; // 0x40007, 0x10007
208+
u32 unk_18; // 0x5, 0x2
209+
u32 unk_1c; // 0x1, 0x1
207210
u32 version;
208-
u32 unk_24[3];
209-
u32 unk_30[12];
211+
u32 unk_24; // 0x7, 0x9
212+
u32 unk_28; // 0x1, 0x1410
213+
u32 unk_2c; // 0x7, 0x2
214+
u32 pad_30[7];
215+
u32 unk_4c; // 0x10000, 0x50000
216+
u32 unk_50; // 0x1, 0x1
217+
u32 unk_54; // 0x0, 0x0
218+
u32 unk_58; // 0x4, 0x4
219+
u32 unk_5c; // 0x10, 0x20
210220
u32 num_presets;
211-
u32 unk_64[7];
212-
u32 unk_80[6];
213-
u32 unk_98_freq;
221+
u32 unk_64; // 0x0, 0x0
222+
u32 unk_68; // 0x44c0, 0x4680
223+
u32 unk_6c; // 0x40, 0x40
224+
u32 unk_70; // 0x1, 0x1
225+
u32 unk_74; // 0x2, 0x2
226+
u32 unk_78; // 0x4000, 0x4000
227+
u32 unk_7c; // 0x40, 0x40
228+
u32 unk_80; // 0x1, 0x1
229+
u32 pad_84[2];
230+
u32 unk_8c; // 0x36, 0x36
231+
u32 pad_90[2];
232+
u32 timestamp_freq;
214233
u16 pad_9c;
215234
char module_sn[20];
216235
u16 pad_b0;
217-
u32 unk_b4[25];
236+
u32 unk_b4; // 0x8, 0x8
237+
u32 pad_b8[2];
238+
u32 unk_c0; // 0x4, 0x1
239+
u32 unk_c4; // 0x0, 0x0
240+
u32 unk_c8; // 0x0, 0x100
241+
u32 pad_cc[4];
242+
u32 unk_dc; // 0xff0000, 0xff0000
243+
u32 unk_e0; // 0xc00, 0xc00
244+
u32 unk_e4; // 0x0, 0x0
245+
u32 unk_e8; // 0x1c, 0x1c
246+
u32 unk_ec; // 0x640, 0x680
247+
u32 unk_f0; // 0x4, 0x4
248+
u32 unk_f4; // 0x4, 0x4
249+
u32 pad_f8[6];
250+
u32 unk_110; // 0x0, 0x7800000
251+
u32 unk_114; // 0x0, 0x780
218252
} __packed;
219253
static_assert(sizeof(struct cmd_ch_info) == 0x118);
220254

@@ -226,7 +260,19 @@ struct cmd_ch_camera_config {
226260
u16 in_height;
227261
u16 out_width;
228262
u16 out_height;
229-
u32 unk[49];
263+
u32 unk_28;
264+
u32 unk_2c;
265+
u32 unk_30[16];
266+
u32 sensor_clk;
267+
u32 unk_64[4];
268+
u32 timestamp_freq;
269+
u32 unk_78[2];
270+
u32 unk_80[16];
271+
u32 in_width2; // repeated in u32??
272+
u32 in_height2;
273+
u32 unk_c8[3];
274+
u32 out_width2;
275+
u32 out_height2;
230276
} __packed;
231277
static_assert(sizeof(struct cmd_ch_camera_config) == 0xdc);
232278

0 commit comments

Comments
 (0)