bcachefs: Fix missing error check in journal_entry_btree_keys_validate()

Kent Overstreet · Kent Overstreet · commit 0f6f8f76936b · 2024-07-10T09:53:39.000-04:00
Closes: https://syzkaller.appspot.com/bug?extid=8996d8f176cf946ef641 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
@@ -415,6 +415,8 @@ static int journal_entry_btree_keys_validate(struct bch_fs *c,
 					       flags|BCH_VALIDATE_journal);
 		if (ret == FSCK_DELETED_KEY)
 			continue;
+		else if (ret)
+			return ret;
 
 		k = bkey_next(k);
 	}

Original file line number	Diff line number	Diff line change
`@@ -415,6 +415,8 @@ static int journal_entry_btree_keys_validate(struct bch_fs *c,`
`415`	`415`	`flags\|BCH_VALIDATE_journal);`
`416`	`416`	`if (ret == FSCK_DELETED_KEY)`
`417`	`417`	`continue;`
	`418`	`+ else if (ret)`
	`419`	`+ return ret;`
`418`	`420`
`419`	`421`	`k = bkey_next(k);`
`420`	`422`	`}`