tty: omit need_resched() before cond_resched()

Mikulas Patocka · gregkh · commit 103f5d8c35b3 · 2025-07-16T11:05:34.000+02:00
There's no need to call need_resched() because cond_resched() will do nothing if need_resched() returns false. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Link: https://lore.kernel.org/r/5a11ad09-5508-933c-f044-6a236bf00557@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
@@ -499,8 +499,7 @@ static void flush_to_ldisc(struct work_struct *work)
 		if (!rcvd)
 			break;
 
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 
 	mutex_unlock(&buf->lock);

Original file line number	Diff line number	Diff line change
`@@ -499,8 +499,7 @@ static void flush_to_ldisc(struct work_struct *work)`
`499`	`499`	`if (!rcvd)`
`500`	`500`	`break;`
`501`	`501`
`502`		`- if (need_resched())`
`503`		`- cond_resched();`
	`502`	`+ cond_resched();`
`504`	`503`	`}`
`505`	`504`
`506`	`505`	`mutex_unlock(&buf->lock);`