Skip to content

Commit 1158220

Browse files
t-8chKAGA-KOKO
authored andcommitted
selftests: vDSO: vdso_test_getrandom: Always print TAP header
The TAP specification requires that the output begins with a header line. If vgetrandom_init() fails and skips the test, that header line is missing. Call vgetrandom_init() after ksft_print_header(). Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/all/20250611-selftests-vdso-fixes-v3-8-e62e37a6bcf5@linutronix.de
1 parent 58265d6 commit 1158220

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

tools/testing/selftests/vDSO/vdso_test_getrandom.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ static void kselftest(void)
242242
pid_t child;
243243

244244
ksft_print_header();
245+
vgetrandom_init();
245246
ksft_set_plan(2);
246247

247248
for (size_t i = 0; i < 1000; ++i) {
@@ -295,8 +296,6 @@ static void usage(const char *argv0)
295296

296297
int main(int argc, char *argv[])
297298
{
298-
vgetrandom_init();
299-
300299
if (argc == 1) {
301300
kselftest();
302301
return 0;
@@ -306,6 +305,9 @@ int main(int argc, char *argv[])
306305
usage(argv[0]);
307306
return 1;
308307
}
308+
309+
vgetrandom_init();
310+
309311
if (!strcmp(argv[1], "bench-single"))
310312
bench_single();
311313
else if (!strcmp(argv[1], "bench-multi"))

0 commit comments

Comments
 (0)