Skip to content

Commit 118eb2c

Browse files
KanjiMonsterbroonie
authored andcommitted
spi: bcm63xx: drop wrong casts in probe()
Both bs->regs and bs->{rx,tx}_io are tagged __iomem, so we shouldn't cast them to anything else. Silences the following sparse warning: drivers/spi/spi-bcm63xx.c:571:22: warning: cast removes address space '__iomem' of expression drivers/spi/spi-bcm63xx.c:571:19: warning: incorrect type in assignment (different address spaces) drivers/spi/spi-bcm63xx.c:571:19: expected unsigned char [noderef] [usertype] __iomem *tx_io drivers/spi/spi-bcm63xx.c:571:19: got unsigned char [usertype] * drivers/spi/spi-bcm63xx.c:572:22: warning: cast removes address space '__iomem' of expression drivers/spi/spi-bcm63xx.c:572:19: warning: incorrect type in assignment (different address spaces) drivers/spi/spi-bcm63xx.c:572:19: expected unsigned char const [noderef] [usertype] __iomem *rx_io drivers/spi/spi-bcm63xx.c:572:19: got unsigned char const [usertype] * Fixes: b42dfed ("spi: add Broadcom BCM63xx SPI controller driver") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20251116093334.17423-1-jonas.gorski@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c94f134 commit 118eb2c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/spi/spi-bcm63xx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,8 +568,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
568568
host->auto_runtime_pm = true;
569569
bs->msg_type_shift = bs->reg_offsets[SPI_MSG_TYPE_SHIFT];
570570
bs->msg_ctl_width = bs->reg_offsets[SPI_MSG_CTL_WIDTH];
571-
bs->tx_io = (u8 *)(bs->regs + bs->reg_offsets[SPI_MSG_DATA]);
572-
bs->rx_io = (const u8 *)(bs->regs + bs->reg_offsets[SPI_RX_DATA]);
571+
bs->tx_io = bs->regs + bs->reg_offsets[SPI_MSG_DATA];
572+
bs->rx_io = bs->regs + bs->reg_offsets[SPI_RX_DATA];
573573

574574
/* Initialize hardware */
575575
ret = clk_prepare_enable(bs->clk);

0 commit comments

Comments
 (0)