EDAC/amd64: Simplify return statement in dct_ecc_enabled()

toblux · bp3tk0v · commit 12378e1c3ff8 · 2025-02-28T13:21:43.000+01:00
Simplify the return statement to improve the code's readability. No functional changes. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com> Link: https://lore.kernel.org/r/20250201130953.1377-2-thorsten.blum@linux.dev
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
@@ -3354,10 +3354,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
 
 	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, str_enabled_disabled(ecc_en));
 
-	if (!ecc_en || !nb_mce_en)
-		return false;
-	else
-		return true;
+	return ecc_en && nb_mce_en;
 }
 
 static bool umc_ecc_enabled(struct amd64_pvt *pvt)

Original file line number	Diff line number	Diff line change
`@@ -3354,10 +3354,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)`
`3354`	`3354`
`3355`	`3355`	`edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, str_enabled_disabled(ecc_en));`
`3356`	`3356`
`3357`		`- if (!ecc_en \|\| !nb_mce_en)`
`3358`		`- return false;`
`3359`		`- else`
`3360`		`- return true;`
	`3357`	`+ return ecc_en && nb_mce_en;`
`3361`	`3358`	`}`
`3362`	`3359`
`3363`	`3360`	`static bool umc_ecc_enabled(struct amd64_pvt *pvt)`