Skip to content

Commit 1315cc2

Browse files
Sean Andersonjic23
authored andcommitted
iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK
AMS_ALARM_THR_DIRECT_MASK should be bit 0, not bit 1. This would cause hysteresis to be enabled with a lower threshold of -28C. The temperature alarm would never deassert even if the temperature dropped below the upper threshold. Fixes: d5c7062 ("iio: adc: Add Xilinx AMS driver") Signed-off-by: Sean Anderson <sean.anderson@linux.dev> Reviewed-by: O'Griofa, Conall <conall.ogriofa@amd.com> Tested-by: Erim, Salih <Salih.Erim@amd.com> Acked-by: Erim, Salih <Salih.Erim@amd.com> Link: https://patch.msgid.link/20250715003058.2035656-1-sean.anderson@linux.dev Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent feb500c commit 1315cc2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/iio/adc/xilinx-ams.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
#define AMS_ALARM_THRESHOLD_OFF_10 0x10
119119
#define AMS_ALARM_THRESHOLD_OFF_20 0x20
120120

121-
#define AMS_ALARM_THR_DIRECT_MASK BIT(1)
121+
#define AMS_ALARM_THR_DIRECT_MASK BIT(0)
122122
#define AMS_ALARM_THR_MIN 0x0000
123123
#define AMS_ALARM_THR_MAX (BIT(16) - 1)
124124

0 commit comments

Comments
 (0)