RDMA/nldev: Set error code in rdma_nl_notify_event

chiarameiohas · rleon · commit 13a6691910cc · 2024-12-19T05:15:20.000-05:00
In case of error set the error code before the goto. Fixes: 6ff57a2 ("RDMA/nldev: Fix NULL pointer dereferences issue in rdma_nl_notify_event") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/linux-rdma/a84a2fc3-33b6-46da-a1bd-3343fa07eaf9@stanley.mountain/ Signed-off-by: Chiara Meiohas <cmeiohas@nvidia.com> Reviewed-by: Maher Sanalla <msanalla@nvidia.com> Link: https://patch.msgid.link/13eb25961923f5de9eb9ecbbc94e26113d6049ef.1733815944.git.leonro@nvidia.com Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
@@ -2833,8 +2833,8 @@ int rdma_nl_notify_event(struct ib_device *device, u32 port_num,
 			  enum rdma_nl_notify_event_type type)
 {
 	struct sk_buff *skb;
+	int ret = -EMSGSIZE;
 	struct net *net;
-	int ret = 0;
 	void *nlh;
 
 	net = read_pnet(&device->coredev.rdma_net);

Original file line number	Diff line number	Diff line change
`@@ -2833,8 +2833,8 @@ int rdma_nl_notify_event(struct ib_device *device, u32 port_num,`
`2833`	`2833`	`enum rdma_nl_notify_event_type type)`
`2834`	`2834`	`{`
`2835`	`2835`	`struct sk_buff *skb;`
	`2836`	`+ int ret = -EMSGSIZE;`
`2836`	`2837`	`struct net *net;`
`2837`		`- int ret = 0;`
`2838`	`2838`	`void *nlh;`
`2839`	`2839`
`2840`	`2840`	`net = read_pnet(&device->coredev.rdma_net);`