Skip to content

Commit 143ddfa

Browse files
DispatchCodepaulmckrcu
authored andcommitted
rcu: replace use of system_wq with system_percpu_wq
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. system_wq is a per-CPU worqueue, yet nothing in its name tells about that CPU affinity constraint, which is very often not required by users. Make it clear by adding a system_percpu_wq. The old wq will be kept for a few release cylces. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent a214365 commit 143ddfa

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

kernel/rcu/tasks.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -553,13 +553,13 @@ static void rcu_tasks_invoke_cbs(struct rcu_tasks *rtp, struct rcu_tasks_percpu
553553
rtpcp_next = rtp->rtpcp_array[index];
554554
if (rtpcp_next->cpu < smp_load_acquire(&rtp->percpu_dequeue_lim)) {
555555
cpuwq = rcu_cpu_beenfullyonline(rtpcp_next->cpu) ? rtpcp_next->cpu : WORK_CPU_UNBOUND;
556-
queue_work_on(cpuwq, system_wq, &rtpcp_next->rtp_work);
556+
queue_work_on(cpuwq, system_percpu_wq, &rtpcp_next->rtp_work);
557557
index++;
558558
if (index < num_possible_cpus()) {
559559
rtpcp_next = rtp->rtpcp_array[index];
560560
if (rtpcp_next->cpu < smp_load_acquire(&rtp->percpu_dequeue_lim)) {
561561
cpuwq = rcu_cpu_beenfullyonline(rtpcp_next->cpu) ? rtpcp_next->cpu : WORK_CPU_UNBOUND;
562-
queue_work_on(cpuwq, system_wq, &rtpcp_next->rtp_work);
562+
queue_work_on(cpuwq, system_percpu_wq, &rtpcp_next->rtp_work);
563563
}
564564
}
565565
}

0 commit comments

Comments
 (0)