Skip to content

Commit 14570c6

Browse files
qianfengrongalexdeucher
authored andcommitted
drm/amd/display: use max() to improve code
Use max() to reduce the code and improve readability. No functional changes. Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 7563e21 commit 14570c6

3 files changed

Lines changed: 4 additions & 15 deletions

File tree

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,11 +1047,8 @@ static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
10471047
&num_entries_per_clk->num_fclk_levels);
10481048
clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = dcn30_smu_get_dc_mode_max_dpm_freq(clk_mgr, PPCLK_FCLK);
10491049

1050-
if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
1051-
num_levels = num_entries_per_clk->num_memclk_levels;
1052-
} else {
1053-
num_levels = num_entries_per_clk->num_fclk_levels;
1054-
}
1050+
num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
1051+
10551052
clk_mgr_base->bw_params->max_memclk_mhz =
10561053
clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_memclk_levels - 1].memclk_mhz;
10571054
clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1404,11 +1404,7 @@ static void dcn401_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
14041404
clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_fclk_levels - 1].fclk_mhz)
14051405
clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = 0;
14061406

1407-
if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
1408-
num_levels = num_entries_per_clk->num_memclk_levels;
1409-
} else {
1410-
num_levels = num_entries_per_clk->num_fclk_levels;
1411-
}
1407+
num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
14121408

14131409
clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
14141410

drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -463,11 +463,7 @@ static void populate_dml21_timing_config_from_stream_state(struct dml2_timing_cf
463463
(stream->timing.h_total * (long long)calc_max_hardware_v_total(stream)));
464464
}
465465

466-
if (stream->timing.min_refresh_in_uhz > min_hardware_refresh_in_uhz) {
467-
timing->drr_config.min_refresh_uhz = stream->timing.min_refresh_in_uhz;
468-
} else {
469-
timing->drr_config.min_refresh_uhz = min_hardware_refresh_in_uhz;
470-
}
466+
timing->drr_config.min_refresh_uhz = max(stream->timing.min_refresh_in_uhz, min_hardware_refresh_in_uhz);
471467

472468
if (dml_ctx->config.callbacks.get_max_flickerless_instant_vtotal_increase &&
473469
stream->ctx->dc->config.enable_fpo_flicker_detection == 1)

0 commit comments

Comments
 (0)