Skip to content

Commit 153c460

Browse files
tobluxgregkh
authored andcommitted
ALSA: intel_hdmi: Fix off-by-one error in __hdmi_lpe_audio_probe()
commit 8cbe564 upstream. In __hdmi_lpe_audio_probe(), strscpy() is incorrectly called with the length of the source string (excluding the NUL terminator) rather than the size of the destination buffer. This results in one character less being copied from 'card->shortname' to 'pcm->name'. Use the destination buffer size instead to ensure the card name is copied correctly. Cc: stable@vger.kernel.org Fixes: 75b1a8f ("ALSA: Convert strlcpy to strscpy when return value is unused") Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Link: https://patch.msgid.link/20250805234156.60294-1-thorsten.blum@linux.dev Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a762a4c commit 153c460

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/x86/intel_hdmi_audio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1767,7 +1767,7 @@ static int __hdmi_lpe_audio_probe(struct platform_device *pdev)
17671767
/* setup private data which can be retrieved when required */
17681768
pcm->private_data = ctx;
17691769
pcm->info_flags = 0;
1770-
strscpy(pcm->name, card->shortname, strlen(card->shortname));
1770+
strscpy(pcm->name, card->shortname, sizeof(pcm->name));
17711771
/* setup the ops for playback */
17721772
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);
17731773

0 commit comments

Comments
 (0)