Skip to content

Commit 166fcf8

Browse files
stonezdmkuba-moo
authored andcommitted
ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
The object "ax25_dev" is managed by reference counting. Thus it should not be directly released by kfree(), replace with ax25_dev_put(). Fixes: d01ffb9 ("ax25: add refcount in ax25_dev to avoid UAF bugs") Suggested-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20240530051733.11416-1-duoming@zju.edu.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 3c34fb0 commit 166fcf8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/ax25/ax25_dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ void __exit ax25_dev_free(void)
196196
list_for_each_entry_safe(s, n, &ax25_dev_list, list) {
197197
netdev_put(s->dev, &s->dev_tracker);
198198
list_del(&s->list);
199-
kfree(s);
199+
ax25_dev_put(s);
200200
}
201201
spin_unlock_bh(&ax25_dev_lock);
202202
}

0 commit comments

Comments
 (0)