Skip to content

Commit 1722fb4

Browse files
andy-shevvinodkoul
authored andcommitted
dmaengine: Add a comment on why it's okay when kasprintf() fails
Add a comment in dma_request_chan() to clarify kasprintf() missing return value check and it is correct functionality. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20250205145757.889247-4-andriy.shevchenko@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 1c83d3d commit 1722fb4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/dma/dmaengine.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -854,8 +854,8 @@ struct dma_chan *dma_request_chan(struct device *dev, const char *name)
854854

855855
found:
856856
#ifdef CONFIG_DEBUG_FS
857-
chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev),
858-
name);
857+
chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev), name);
858+
/* No functional issue if it fails, users are supposed to test before use */
859859
#endif
860860

861861
chan->name = kasprintf(GFP_KERNEL, "dma:%s", name);

0 commit comments

Comments
 (0)