Skip to content

Commit 1793ce9

Browse files
rddunlapAbhinav Kumar
authored andcommitted
drm/msm/dpu: fix kernel-doc warnings
Correct all kernel-doc warnings in dpu_encoder.c and dpu_rm.c: dpu_encoder.c:212: warning: Excess struct member 'crtc_kickoff_cb' description in 'dpu_encoder_virt' dpu_encoder.c:212: warning: Excess struct member 'crtc_kickoff_cb_data' description in 'dpu_encoder_virt' dpu_encoder.c:212: warning: Excess struct member 'debugfs_root' description in 'dpu_encoder_virt' dpu_rm.c:35: warning: Excess struct member 'hw_res' description in 'dpu_rm_requirements' dpu_rm.c:208: warning: No description found for return value of '_dpu_rm_get_lm_peer' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: Marijn Suijten <marijn.suijten@somainline.org> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Vegard Nossum <vegard.nossum@oracle.com> Reviewed-by: Paloma Arellano <quic_parellan@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202312170641.5exlvQQx-lkp@intel.com/ Fixes: 62d3562 ("drm/msm/dpu: move encoder status to standard encoder debugfs dir") Fixes: 25fdd59 ("drm/msm: Add SDM845 DPU support") Patchwork: https://patchwork.freedesktop.org/patch/572962/ Link: https://lore.kernel.org/r/20231231060823.1934-1-rdunlap@infradead.org Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
1 parent d4ca26a commit 1793ce9

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ enum dpu_enc_rc_states {
144144
* to track crtc in the disable() hook which is called
145145
* _after_ encoder_mask is cleared.
146146
* @connector: If a mode is set, cached pointer to the active connector
147-
* @crtc_kickoff_cb: Callback into CRTC that will flush & start
148-
* all CTL paths
149-
* @crtc_kickoff_cb_data: Opaque user data given to crtc_kickoff_cb
150-
* @debugfs_root: Debug file system root file node
151147
* @enc_lock: Lock around physical encoder
152148
* create/destroy/enable/disable
153149
* @frame_busy_mask: Bitmask tracking which phys_enc we are still

drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ static inline bool reserved_by_other(uint32_t *res_map, int idx,
2929
/**
3030
* struct dpu_rm_requirements - Reservation requirements parameter bundle
3131
* @topology: selected topology for the display
32-
* @hw_res: Hardware resources required as reported by the encoders
3332
*/
3433
struct dpu_rm_requirements {
3534
struct msm_display_topology topology;
@@ -204,6 +203,8 @@ static bool _dpu_rm_needs_split_display(const struct msm_display_topology *top)
204203
* _dpu_rm_get_lm_peer - get the id of a mixer which is a peer of the primary
205204
* @rm: dpu resource manager handle
206205
* @primary_idx: index of primary mixer in rm->mixer_blks[]
206+
*
207+
* Returns: lm peer mixed id on success or %-EINVAL on error
207208
*/
208209
static int _dpu_rm_get_lm_peer(struct dpu_rm *rm, int primary_idx)
209210
{

0 commit comments

Comments
 (0)