Skip to content

Commit 17c40f3

Browse files
arndblag-linaro
authored andcommitted
leds: blinkm: Fix CONFIG_LEDS_CLASS_MULTICOLOR dependency
With CONFIG_LEDS_CLASS_MULTICOLOR=m, a builtin leds-blinkm driver causes a link failure: arm-linux-gnueabi-ld: drivers/leds/leds-blinkm.o: in function `blinkm_set_mc_brightness': leds-blinkm.c:(.text.blinkm_set_mc_brightness+0xc): undefined reference to `led_mc_calc_color_components' Add a more specific dependency that only allows multicoler mode to be enabled for blinkm if it can build and link. Fixes: 56e8c56 ("leds: Add multicolor support to BlinkM LED driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Joseph Strauss <jstrauss@mailbox.org> Link: https://lore.kernel.org/r/20240807075614.2118068-1-arnd@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 82c5ada commit 17c40f3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/leds/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ config LEDS_BLINKM
828828
config LEDS_BLINKM_MULTICOLOR
829829
bool "Enable multicolor support for BlinkM I2C RGB LED"
830830
depends on LEDS_BLINKM
831-
depends on LEDS_CLASS_MULTICOLOR
831+
depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=LEDS_BLINKM
832832
help
833833
This option enables multicolor sysfs class support for BlinkM LED and
834834
disables the older, separated sysfs interface

0 commit comments

Comments
 (0)