apple-nvme: Release power domains when probe fails

marcan · jannau · commit 185472e0be3b · 2024-08-15T00:30:01.000+02:00
Signed-off-by: Hector Martin &lt;marcan@marcan.st&gt;
diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
@@ -1578,6 +1578,7 @@ static struct apple_nvme *apple_nvme_alloc(struct platform_device *pdev)
 
 	return anv;
 put_dev:
+	apple_nvme_detach_genpd(anv);
 	put_device(anv->dev);
 	return ERR_PTR(ret);
 }
@@ -1614,6 +1615,7 @@ static int apple_nvme_probe(struct platform_device *pdev)
 out_uninit_ctrl:
 	nvme_uninit_ctrl(&anv->ctrl);
 	nvme_put_ctrl(&anv->ctrl);
+	apple_nvme_detach_genpd(anv);
 	return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1578,6 +1578,7 @@ static struct apple_nvme apple_nvme_alloc(struct platform_device pdev)`
`1578`	`1578`
`1579`	`1579`	`return anv;`
`1580`	`1580`	`put_dev:`
	`1581`	`+ apple_nvme_detach_genpd(anv);`
`1581`	`1582`	`put_device(anv->dev);`
`1582`	`1583`	`return ERR_PTR(ret);`
`1583`	`1584`	`}`
`@@ -1614,6 +1615,7 @@ static int apple_nvme_probe(struct platform_device *pdev)`
`1614`	`1615`	`out_uninit_ctrl:`
`1615`	`1616`	`nvme_uninit_ctrl(&anv->ctrl);`
`1616`	`1617`	`nvme_put_ctrl(&anv->ctrl);`
	`1618`	`+ apple_nvme_detach_genpd(anv);`
`1617`	`1619`	`return ret;`
`1618`	`1620`	`}`
`1619`	`1621`