Skip to content

Commit 1a97454

Browse files
shimodaykwilczynski
authored andcommitted
PCI: tegra194: Drop PCI_EXP_LNKSTA_NLW setting
dw_pcie_setup() is already setting PCI_EXP_LNKCAP_MLW to pcie->num_lanes in the PCI_EXP_LNKCAP register for programming maximum link width. Hence, remove the redundant setting here. Link: https://lore.kernel.org/linux-pci/20231018085631.1121289-5-yoshihiro.shimoda.uh@renesas.com Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com>
1 parent 89db079 commit 1a97454

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/pci/controller/dwc/pcie-tegra194.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -917,12 +917,6 @@ static int tegra_pcie_dw_host_init(struct dw_pcie_rp *pp)
917917
AMBA_ERROR_RESPONSE_CRS_SHIFT);
918918
dw_pcie_writel_dbi(pci, PORT_LOGIC_AMBA_ERROR_RESPONSE_DEFAULT, val);
919919

920-
/* Configure Max lane width from DT */
921-
val = dw_pcie_readl_dbi(pci, pcie->pcie_cap_base + PCI_EXP_LNKCAP);
922-
val &= ~PCI_EXP_LNKCAP_MLW;
923-
val |= (pcie->num_lanes << PCI_EXP_LNKSTA_NLW_SHIFT);
924-
dw_pcie_writel_dbi(pci, pcie->pcie_cap_base + PCI_EXP_LNKCAP, val);
925-
926920
/* Clear Slot Clock Configuration bit if SRNS configuration */
927921
if (pcie->enable_srns) {
928922
val_16 = dw_pcie_readw_dbi(pci, pcie->pcie_cap_base +

0 commit comments

Comments
 (0)