Skip to content

Commit 1af52d0

Browse files
committed
drm/i915/adlp: Add MST short HBlank WA (Wa_14014143976)
Add a workaround to fix BS jitter issues on MST links if the HBLANK period is less than 1 MTP. The WA applies only to UHBR rates while on non-UHBR the specification requires disabling it explicitly - presumedly because the register's reset value has the WA enabled. Bspec: 50050, 55424 Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240129175533.904590-3-imre.deak@intel.com
1 parent 9655a9a commit 1af52d0

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

drivers/gpu/drm/i915/display/intel_dp_mst.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,6 +1135,14 @@ static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
11351135
if (crtc_state->fec_enable || intel_dp_is_uhbr(crtc_state))
11361136
set |= DP_MST_FEC_BS_JITTER_WA(crtc_state->cpu_transcoder);
11371137

1138+
/* Wa_14014143976:adlp */
1139+
if (IS_DISPLAY_STEP(i915, STEP_E0, STEP_FOREVER)) {
1140+
if (intel_dp_is_uhbr(crtc_state))
1141+
set |= DP_MST_SHORT_HBLANK_WA(crtc_state->cpu_transcoder);
1142+
else if (crtc_state->fec_enable)
1143+
clear |= DP_MST_SHORT_HBLANK_WA(crtc_state->cpu_transcoder);
1144+
}
1145+
11381146
if (!clear && !set)
11391147
return;
11401148

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4565,6 +4565,7 @@
45654565
#define GLK_CL0_PWR_DOWN REG_BIT(10)
45664566

45674567
#define CHICKEN_MISC_3 _MMIO(0x42088)
4568+
#define DP_MST_SHORT_HBLANK_WA(trans) REG_BIT(5 + (trans) - TRANSCODER_A)
45684569
#define DP_MST_FEC_BS_JITTER_WA(trans) REG_BIT(0 + (trans) - TRANSCODER_A)
45694570

45704571
#define CHICKEN_MISC_4 _MMIO(0x4208c)

0 commit comments

Comments
 (0)