Skip to content

Commit 1b2f5d5

Browse files
Christoph Hellwigkeithbusch
authored andcommitted
nvme: remove nvme_revalidate_zones
Handle setting the zone size / chunk_sectors and max_append_sectors limits together with the other ZNS limits, and just open code the call to blk_revalidate_zones in the current place. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent 63dfa10 commit 1b2f5d5

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

drivers/nvme/host/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2154,7 +2154,7 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns,
21542154
blk_mq_unfreeze_queue(ns->disk->queue);
21552155

21562156
if (blk_queue_is_zoned(ns->queue)) {
2157-
ret = nvme_revalidate_zones(ns);
2157+
ret = blk_revalidate_disk_zones(ns->disk, NULL);
21582158
if (ret && !nvme_first_scan(ns->disk))
21592159
goto out;
21602160
}

drivers/nvme/host/nvme.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,6 @@ static inline bool nvme_disk_is_ns_head(struct gendisk *disk)
10361036
}
10371037
#endif /* CONFIG_NVME_MULTIPATH */
10381038

1039-
int nvme_revalidate_zones(struct nvme_ns *ns);
10401039
int nvme_ns_report_zones(struct nvme_ns *ns, sector_t sector,
10411040
unsigned int nr_zones, report_zones_cb cb, void *data);
10421041
#ifdef CONFIG_BLK_DEV_ZONED

drivers/nvme/host/zns.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,6 @@
77
#include <linux/vmalloc.h>
88
#include "nvme.h"
99

10-
int nvme_revalidate_zones(struct nvme_ns *ns)
11-
{
12-
struct request_queue *q = ns->queue;
13-
14-
blk_queue_chunk_sectors(q, ns->head->zsze);
15-
blk_queue_max_zone_append_sectors(q, ns->ctrl->max_zone_append);
16-
17-
return blk_revalidate_disk_zones(ns->disk, NULL);
18-
}
19-
2010
static int nvme_set_max_append(struct nvme_ctrl *ctrl)
2111
{
2212
struct nvme_command c = { };
@@ -113,6 +103,8 @@ int nvme_update_zone_info(struct nvme_ns *ns, unsigned lbaf)
113103
blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, q);
114104
disk_set_max_open_zones(ns->disk, le32_to_cpu(id->mor) + 1);
115105
disk_set_max_active_zones(ns->disk, le32_to_cpu(id->mar) + 1);
106+
blk_queue_chunk_sectors(ns->queue, ns->head->zsze);
107+
blk_queue_max_zone_append_sectors(ns->queue, ns->ctrl->max_zone_append);
116108
free_data:
117109
kfree(id);
118110
return status;

0 commit comments

Comments
 (0)