HID: pidff: Remove redundant call to pidff_find_special_keys

Lawstorant · Jiri Kosina · commit 1bd55e79cbc0 · 2025-02-11T23:15:33.000+01:00
Probably left out as a mistake after Anssi created the helper macro

Signed-off-by: Tomasz Pakuła &lt;tomasz.pakula.oficjalny@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
@@ -1159,10 +1159,6 @@ static int pidff_find_special_fields(struct pidff_device *pidff)
 		return -1;
 	}
 
-	pidff_find_special_keys(pidff->control_id, pidff->device_control,
-				pidff_device_control,
-				sizeof(pidff_device_control));
-
 	PIDFF_FIND_SPECIAL_KEYS(control_id, device_control, device_control);
 
 	if (!PIDFF_FIND_SPECIAL_KEYS(type_id, create_new_effect_type,

Original file line number	Diff line number	Diff line change
`@@ -1159,10 +1159,6 @@ static int pidff_find_special_fields(struct pidff_device *pidff)`
`1159`	`1159`	`return -1;`
`1160`	`1160`	`}`
`1161`	`1161`
`1162`		`- pidff_find_special_keys(pidff->control_id, pidff->device_control,`
`1163`		`- pidff_device_control,`
`1164`		`- sizeof(pidff_device_control));`
`1165`		`-`
`1166`	`1162`	`PIDFF_FIND_SPECIAL_KEYS(control_id, device_control, device_control);`
`1167`	`1163`
`1168`	`1164`	`if (!PIDFF_FIND_SPECIAL_KEYS(type_id, create_new_effect_type,`