Skip to content

Commit 1cf74da

Browse files
Bartosz Golaszewskigeertu
authored andcommitted
soc: renesas: pwc-rzv2m: Use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/20250610-gpiochip-set-rv-soc-v1-2-1a0c36c9deed@linaro.org Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
1 parent c7968f5 commit 1cf74da

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/soc/renesas/pwc-rzv2m.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ struct rzv2m_pwc_priv {
2424
DECLARE_BITMAP(ch_en_bits, 2);
2525
};
2626

27-
static void rzv2m_pwc_gpio_set(struct gpio_chip *chip, unsigned int offset,
28-
int value)
27+
static int rzv2m_pwc_gpio_set(struct gpio_chip *chip, unsigned int offset,
28+
int value)
2929
{
3030
struct rzv2m_pwc_priv *priv = gpiochip_get_data(chip);
3131
u32 reg;
@@ -38,6 +38,8 @@ static void rzv2m_pwc_gpio_set(struct gpio_chip *chip, unsigned int offset,
3838
writel(reg, priv->base + PWC_GPIO);
3939

4040
assign_bit(offset, priv->ch_en_bits, value);
41+
42+
return 0;
4143
}
4244

4345
static int rzv2m_pwc_gpio_get(struct gpio_chip *chip, unsigned int offset)
@@ -62,7 +64,7 @@ static const struct gpio_chip rzv2m_pwc_gc = {
6264
.label = "gpio_rzv2m_pwc",
6365
.owner = THIS_MODULE,
6466
.get = rzv2m_pwc_gpio_get,
65-
.set = rzv2m_pwc_gpio_set,
67+
.set_rv = rzv2m_pwc_gpio_set,
6668
.direction_output = rzv2m_pwc_gpio_direction_output,
6769
.can_sleep = false,
6870
.ngpio = 2,

0 commit comments

Comments
 (0)